doc: add section regarding property definition in primordials.md#42921
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
Review requested:
|
aduh95 added the author ready 
Member
tniessen left a comment
tniessen left a comment There was a problem hiding this comment.
This should probably justify why it matters for ObjectDefineProperty, but not for every other use case of object literals within node.
marsonya approved these changes May 1, 2022
ContributorAuthor
aduh95 commented May 1, 2022
I've tried to come up with examples that demonstrate that, I'm open to suggestions if you see possible improvements. |
aduh95 added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented May 2, 2022
Landed in 52ba02e |
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
PR-URL: #42921 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #42921 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
aduh95 added a commit to aduh95/node that referenced this pull request May 31, 2022
nodejs-github-bot pushed a commit that referenced this pull request Jun 3, 2022
Refs: #42921 PR-URL: #43270 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
Refs: nodejs#42921 PR-URL: nodejs#43270 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
Refs: #42921 PR-URL: #43270 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
Refs: #42921 PR-URL: #43270 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #42921 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #42921 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 18, 2022
Refs: #42921 PR-URL: #43270 Backport-PR-URL: #43804 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #42921 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Refs: #42921 PR-URL: #43270 Backport-PR-URL: #43804 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42921 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#42921 PR-URL: nodejs/node#43270 Backport-PR-URL: nodejs/node#43804 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
Refs: nodejs/node#42921 PR-URL: nodejs/node#43270 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.