Skip to content

Conversation

@batrla
Copy link
Contributor

closes#42827

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 2, 2022
@mhdawson
Copy link
Member

@danbev can you take a look at this one?

@nodejs-github-bot
Copy link
Collaborator

@tniessentniessen requested a review from bnoordhuisMay 3, 2022 13:11
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

Landed in 2454aa0

@mhdawsonmhdawson closed this May 4, 2022
mhdawson pushed a commit that referenced this pull request May 4, 2022
Fixes: #42827 PR-URL: #42947 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
Fixes: #42827 PR-URL: #42947 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request May 10, 2022
@juanarbol
Copy link
Member

OpenSSL 3 is not part of v16.x

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test/parallel/test-crypto-fips.js fails if node is built with --shared-openssl and --openssl-is-fips

7 participants

@batrla@mhdawson@nodejs-github-bot@juanarbol@bnoordhuis@danbev@tniessen