src: TraceEventScope should mark sync duration events#42977
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
github-actionsbot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
Uh oh!
There was an error while loading. Please reload this page.
RaisinTen approved these changes May 8, 2022
Member
RaisinTen left a comment
RaisinTen left a comment There was a problem hiding this comment.
LGTM apart from one tiny optional nitpick.
Uh oh!
There was an error while loading. Please reload this page.
RaisinTen added the author ready Collaborator
nodejs-github-bot commented May 8, 2022
Member
jasnell commented May 8, 2022
Not sure if this is the correct fix. They were implemented the way they were so that we can trace how long these various methods take to complete so we can better determine if changes introduce performance regressions. That said, they likely aren't broadly used and everything under trace events is still considered experimental and therefore breaking changes are ok. |
MemberAuthor
The duration events do contain the timestamps on which we can trace how long these methods take to complete, as same as async events. However, synchronous duration events also suggest that these methods are performed in one single thread for a period of time, while async events are not and can be performed intermittently. @jasnell I'm not sure what you mean by "correct fix". Do you suggest that the methods changed in this PR can be performed in different threads for a given unique id or intermittently? |
30 tasks
MemberAuthor
legendecas commented May 12, 2022
@jasnell would you mind elaborating your suggestion here? This PR has opened for 7 days but I'd still like to know your opinions before landing. Thank you. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented May 12, 2022
This was referenced May 12, 2022
Collaborator
nodejs-github-bot commented May 13, 2022
Collaborator
nodejs-github-bot commented May 13, 2022
Collaborator
nodejs-github-bot commented May 13, 2022
33 tasks
Collaborator
nodejs-github-bot commented May 14, 2022
Collaborator
nodejs-github-bot commented May 14, 2022
28 tasks
Collaborator
nodejs-github-bot commented May 15, 2022
Collaborator
nodejs-github-bot commented May 15, 2022
Collaborator
nodejs-github-bot commented May 15, 2022
Collaborator
nodejs-github-bot commented May 15, 2022
Collaborator
nodejs-github-bot commented May 15, 2022
25 tasks
Collaborator
nodejs-github-bot commented May 16, 2022
MemberAuthor
legendecas commented May 16, 2022
Landed in 7035186 |
legendecas added a commit that referenced this pull request May 16, 2022
According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread. PR-URL: #42977 Reviewed-By: Darshan Sen <[email protected]>
This was referenced May 17, 2022
bengl pushed a commit that referenced this pull request May 30, 2022
According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread. PR-URL: #42977 Reviewed-By: Darshan Sen <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread. PR-URL: #42977 Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread. PR-URL: #42977 Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread. PR-URL: #42977 Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread. PR-URL: #42977 Reviewed-By: Darshan Sen <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread. PR-URL: nodejs/node#42977 Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the chrome trace event format document, works that are performed on one single thread should be traced with sync duration events. In this way, these events can be grouped under one thread and the trace event viewer can estimate the CPU usage of that thread.
click to see screen shots
Before:
Note that there are no events recorded in the JavaScriptMainThread nor WorkerThread 1.
After:
Environment events like cleanup are correctly grouped under their thread.