net: remoteAddress always undefined called before connected#43011
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented May 8, 2022
Review requested:
|
nodejs-github-bot added needs-ci 
Contributor
ShogunPanda commented May 8, 2022
Can you link that PR so I can take a look tomorrow? |
himself65 approved these changes May 8, 2022
lpinca approved these changes May 8, 2022
ContributorAuthor
Y1D7NG commented May 17, 2022
can this be merged? |
Contributor
ShogunPanda commented May 17, 2022
At least two approvals and 48 hours passed. I think we're good to go! |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented May 18, 2022
27 tasks
Collaborator
nodejs-github-bot commented May 19, 2022
Collaborator
nodejs-github-bot commented May 19, 2022
Contributor
ShogunPanda commented May 19, 2022
Landed in b88045f |
ShogunPanda pushed a commit that referenced this pull request May 19, 2022
PR-URL: #43011 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced May 20, 2022
bengl pushed a commit that referenced this pull request May 30, 2022
PR-URL: #43011 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
juanarbol commented May 31, 2022
This seems to in break v16.x: make[1]: Leavingdirectory'/home/juanarbol/GitHub/node/test/node-api/test_worker_terminate/build'/usr/bin/python3.10tools/test.py--mode=release \ \ --skip-tests= \ default \ addonsjs-native-apinode-api===releasetest-net-remote-address-port===Path: parallel/test-net-remote-address-port node:assert:399throwerr;^AssertionError[ERR_ASSERTION]: Theexpressionevaluatedtoafalsy value: assert.ok(remoteFamilyCandidates.includes(socket.remoteFamily))atServer.<anonymous>(/home/juanarbol/GitHub/node/test/parallel/test-net-remote-address-port.js:38:10)atServer.<anonymous>(/home/juanarbol/GitHub/node/test/common/index.js:417:15)atServer.emit(node:events:527:28)atTCP.onconnection(node:net:1634:8){generatedMessage: true,code: 'ERR_ASSERTION',actual: false,expected: true,operator: '=='}not really sure why, I will label this one as backport-requested in the meantime |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix#43009
connectingand get remote address, family and port, returnthis._peername ||{}directly.remoteFamilyisIPvundefinedwhen it doesn't exis, returnundefinedif it does not exist.