doc: use serial comma in util docs#43063
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
Trott approved these changes May 12, 2022
VoltrexKeyva approved these changes May 12, 2022
tniessen removed the fast-track 
MemberAuthor
tniessen commented May 12, 2022
Fast-track action failed, presumably a GitHub error: |
Contributor
Fast-track has been requested by @tniessen. Please 👍 to approve. |
RaisinTen approved these changes May 12, 2022
tniessen added the commit-queue nodejs-github-bot added commit-queue-failed 
Collaborator
nodejs-github-bot commented May 12, 2022
Commit Queue failed- Loading data for nodejs/node/pull/43063 ✔ Done loading data for nodejs/node/pull/43063 ----------------------------------- PR info ------------------------------------ Title doc: use serial comma in util docs (#43063) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:doc-serial-comma-util -> nodejs:master Labels util, doc, fast-track Commits 1 - doc: use serial comma in util docs Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/43063 Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43063 Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 12 May 2022 00:28:34 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-970127656 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43063#pullrequestreview-970134049 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-971111627 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2315851490 |
tniessen added commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented May 12, 2022
Commit Queue failed- Loading data for nodejs/node/pull/43063 ✔ Done loading data for nodejs/node/pull/43063 ----------------------------------- PR info ------------------------------------ Title doc: use serial comma in util docs (#43063) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:doc-serial-comma-util -> nodejs:master Labels util, doc, fast-track Commits 1 - doc: use serial comma in util docs Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/43063 Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43063 Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 12 May 2022 00:28:34 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-970127656 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43063#pullrequestreview-970134049 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-971111627 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2316043100 |
MemberAuthor
tniessen commented May 12, 2022
The first failed |
tniessen added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented May 12, 2022
Landed in 5e6f9c3 |
BethGriggs pushed a commit that referenced this pull request May 16, 2022
Refs: #11321 Refs: #17384 PR-URL: #43063 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43063 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Refs: #11321 Refs: #17384 PR-URL: #43063 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
Refs: #11321 Refs: #17384 PR-URL: #43063 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43063 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321 Refs: nodejs/node#17384 PR-URL: nodejs/node#43063 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node/doc/README.md
Line 21 in 5e9274a
Refs: #11321
Refs: #17384