Skip to content

Conversation

@tniessen
Copy link
Member

*[Use serial commas][].

Refs: #11321
Refs: #17384

@tniessentniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 14, 2022
Copy link
Member

@LiviaMedeirosLiviaMedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits, feel free to ignore or leave for later:

`data` can be a string, a buffer, an{AsyncIterable} or{Iterable} object.

`fs.open()`, `fs.readFile()` or `fs.writeFile()`. Doing

`fs.open()`, `fs.readFile()` or `fs.writeFile()` is not recommended. Doing

`fs.open()`, `fs.readFile()` or `fs.writeFile()` is not recommended.

through `fs.open()` or `fs.writeFile()` or `fsPromises.open()`) will fail with

Out of curiosity, maybe comma should be used in those as well, since any TypedArray is equivalent of Int8Array, ..., or Float64Array:

node/doc/api/fs.md

Lines 4395 to 4396 in 4d5bbc7

description: The `buffer` parameter can now be any `TypedArray` or a
`DataView`.

@tniessentniessenforce-pushed the doc-serial-comma-fs branch from 1238886 to d9a91c4CompareMay 15, 2022 14:18
@tniessen
Copy link
MemberAuthor

Thanks @LiviaMedeiros, I missed those! Force-pushed, the actual diff since the first commit is 1238886. PTAL.

@tniessentniessenforce-pushed the doc-serial-comma-fs branch from cf0fb14 to 4aac703CompareMay 15, 2022 16:45
@tniessen
Copy link
MemberAuthor

Thanks for catching that @LiviaMedeiros! Force-pushed again, the actual diff is cf0fb14.

@LiviaMedeirosLiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2022
@nodejs-github-botnodejs-github-bot merged commit d1d30d7 into nodejs:masterMay 15, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in d1d30d7

BethGriggs pushed a commit that referenced this pull request May 16, 2022
Refs: #11321 Refs: #17384 PR-URL: #43104 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request May 16, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43104 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Refs: #11321 Refs: #17384 PR-URL: #43104 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
Refs: #11321 Refs: #17384 PR-URL: #43104 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43104 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321 Refs: nodejs/node#17384 PR-URL: nodejs/node#43104 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen@nodejs-github-bot@Trott@RaisinTen@LiviaMedeiros