Skip to content

src: reuse GetServerName#43168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
May 21, 2022
Merged

src: reuse GetServerName #43168

nodejs-github-bot merged 1 commit into from
May 21, 2022

Conversation

@tniessen
Copy link
Member

@tniessentniessen commented May 21, 2022

GetServerName(...) is essentially an alias for SSL_get_servername(..., TLSEXT_NAMETYPE_host_name) so reuse it.

@tniessentniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 21, 2022

Review requested:

  • @nodejs/crypto

@github-actions
Copy link
Contributor

github-actionsbot commented May 21, 2022

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 21, 2022
@tniessentniessen added the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 21, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44097/

@aduh95
Copy link
Contributor

aduh95 commented May 21, 2022

For reference:

node/src/crypto/crypto_common.cc

Lines 216 to 218 in 06ba40a

constchar* GetServerName(SSL* ssl){
returnSSL_get_servername(ssl, TLSEXT_NAMETYPE_host_name);
}

@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 21, 2022
@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2022
@nodejs-github-botnodejs-github-bot merged commit 5ba30d8 into nodejs:masterMay 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 21, 2022

Landed in 5ba30d8

This was referenced May 22, 2022
Open
Open
Open
Open
Open
bengl pushed a commit that referenced this pull request May 30, 2022
@tniessen@bengl
src: reuse GetServerName
1e2552b
PR-URL: #43168 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@benglbengl mentioned this pull request May 31, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@tniessen@juanarbol
src: reuse GetServerName
115a04f
PR-URL: #43168 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@tniessen@danielleadams
src: reuse GetServerName
4333264
PR-URL: #43168 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen@targos
src: reuse GetServerName
ffa74dd
PR-URL: #43168 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen@targos
src: reuse GetServerName
eb2c504
PR-URL: #43168 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen@guangwong
src: reuse GetServerName
37f3792
PR-URL: nodejs/node#43168 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tniessen@nodejs-github-bot@aduh95@cjihrig