Skip to content

src: fix json utils escapes for U+000B#43206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
legendecas wants to merge 1 commit into from
Closed

src: fix json utils escapes for U+000B #43206

legendecas wants to merge 1 commit into from

Conversation

@legendecas
Copy link
Member

@legendecaslegendecas commented May 25, 2022•
edited
Loading

According to the https://www.ecma-international.org/wp-content/uploads/ECMA-404_2nd_edition_december_2017.pdf section 9 String, there are only the following two-character escape sequences:

  • \" represents the quotation mark character (U+0022).
  • \\ represents the reverse solidus character (U+005C).
  • \/ represents the solidus character (U+002F).
  • \b represents the backspace character (U+0008).
  • \f represents the form feed character (U+000C).
  • \n represents the line feed character (U+000A).
  • \r represents the carriage return character (U+000D).
  • \t represents the character tabulation character (U+0009).

\v is not one of them. So it should be escaped with hexadecimal sequence.

Fixes: #43193

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 25, 2022
@legendecaslegendecas marked this pull request as ready for review May 25, 2022 15:37
@legendecaslegendecas requested a review from addaleaxMay 26, 2022 14:58
mhdawson
mhdawson approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 27, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44196/

This was referenced May 28, 2022
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 30, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44243/

@github-actionsgithub-actionsbot mentioned this pull request May 31, 2022
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 31, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44250/

@github-actionsgithub-actionsbot mentioned this pull request Jun 1, 2022
Open
17 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 1, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44271/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 1, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44297/

@github-actionsgithub-actionsbot mentioned this pull request Jun 2, 2022
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 2, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44319/

This was referenced Jun 3, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 5, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44371/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 6, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44382/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 6, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44384/

@legendecaslegendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 10, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44420/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 10, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44424/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44464/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44468/

@github-actionsgithub-actionsbot mentioned this pull request Jun 13, 2022
Open
15 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 13, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44480/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 13, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44505/

@github-actionsgithub-actionsbot mentioned this pull request Jun 14, 2022
Open
16 tasks
legendecas added a commit that referenced this pull request Jun 14, 2022
@legendecas
src: fix json utils escapes for U+000B
486dcd7
PR-URL: #43206Fixes: #43193 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
@legendecas
Copy link
MemberAuthor

legendecas commented Jun 14, 2022

Landed in 486dcd7

@legendecaslegendecas deleted the issue-43193 branch June 14, 2022 03:56
danielleadams pushed a commit that referenced this pull request Jun 14, 2022
@legendecas@danielleadams
src: fix json utils escapes for U+000B
a056840
PR-URL: #43206Fixes: #43193 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jun 14, 2022
Merged
@github-actionsgithub-actionsbot mentioned this pull request Jun 15, 2022
Open
17 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
@legendecas@targos
src: fix json utils escapes for U+000B
fbe35e3
PR-URL: #43206Fixes: #43193 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@legendecas@targos
src: fix json utils escapes for U+000B
094d5fc
PR-URL: #43206Fixes: #43193 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
Merged
@jonaldingerjonaldinger mentioned this pull request Aug 18, 2022
Closed
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@legendecas@guangwong
src: fix json utils escapes for U+000B
e2a80f9
PR-URL: nodejs/node#43206Fixes: nodejs/node#43193 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@JungMinuJungMinuJungMinu approved these changes

@richardlaurichardlaurichardlau approved these changes

@mhdawsonmhdawsonmhdawson approved these changes

@addaleaxaddaleaxAwaiting requested review from addaleax

+1 more reviewer

@tony-gotony-gotony-go approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JSON Parse error in internal/process/report?

7 participants

@legendecas@nodejs-github-bot@jasnell@JungMinu@richardlau@mhdawson@tony-go