build: add nonpm and nocorepack to vcbuild.bat#43219
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `./configure` script allows you to produce a build without npm and corepack with the `--without-npm` and `--without-corepack` options respectively, so this change adds the same capability to the `vcbuild.bat` script. Signed-off-by: Darshan Sen <[email protected]>
nodejs-github-bot added build 
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented May 27, 2022
lpinca approved these changes May 27, 2022
19 tasks
RaisinTen added the author ready This was referenced May 29, 2022
aduh95 approved these changes Jun 2, 2022
Contributor
aduh95 left a comment
aduh95 left a comment There was a problem hiding this comment.
Was there really no way of building Node.js without npm and Corepack before on Windows oO
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jun 2, 2022
Landed in 9a11ea1 |
MemberAuthor
RaisinTen commented Jun 2, 2022
Yea, exactly! I too was surprised when I found out. |
italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
The `./configure` script allows you to produce a build without npm and corepack with the `--without-npm` and `--without-corepack` options respectively, so this change adds the same capability to the `vcbuild.bat` script. Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#43219 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
The `./configure` script allows you to produce a build without npm and corepack with the `--without-npm` and `--without-corepack` options respectively, so this change adds the same capability to the `vcbuild.bat` script. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43219 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
The `./configure` script allows you to produce a build without npm and corepack with the `--without-npm` and `--without-corepack` options respectively, so this change adds the same capability to the `vcbuild.bat` script. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43219 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
The `./configure` script allows you to produce a build without npm and corepack with the `--without-npm` and `--without-corepack` options respectively, so this change adds the same capability to the `vcbuild.bat` script. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43219 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
The `./configure` script allows you to produce a build without npm and corepack with the `--without-npm` and `--without-corepack` options respectively, so this change adds the same capability to the `vcbuild.bat` script. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43219 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
The `./configure` script allows you to produce a build without npm and corepack with the `--without-npm` and `--without-corepack` options respectively, so this change adds the same capability to the `vcbuild.bat` script. Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs/node#43219 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
./configurescript allows you to produce a build without npm andcorepack with the
--without-npmand--without-corepackoptionsrespectively, so this change adds the same capability to the
vcbuild.batscript.Signed-off-by: Darshan Sen [email protected]