[v16.x backport] node-api,src: fix module registration in MSVC C++#43293
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jun 1, 2022
Review requested:
|
nodejs-github-bot added c++ 
PR-URL: nodejs#42459 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Backport-PR-URL: nodejs#43293
vmorozforce-pushed the backport-42459-to-v16.x branch from 49e15b3 to 9669f0fCompare
Flarna approved these changes Jun 2, 2022
Member
The only diff to the original PR is in |
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
JungMinu approved these changes Jun 2, 2022
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
MemberAuthor
vmoroz commented Jun 3, 2022
Yes, it was done to fix the previously reported issue. |
Collaborator
nodejs-github-bot commented Jun 3, 2022
21 tasks
danielleadams pushed a commit that referenced this pull request Jun 23, 2022
PR-URL: #42459 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Backport-PR-URL: #43293
Contributor
danielleadams commented Jun 23, 2022
Landed in 5ebed62 |
danielleadams pushed a commit that referenced this pull request Jul 7, 2022
PR-URL: #42459 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Backport-PR-URL: #43293
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42459 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Backport-PR-URL: nodejs/node#43293
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #42459 to v16.x