[v16.x] deps: cherry-pick 4ab70f6 from V8 upstream#43328
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
[Compiler] Remove untrusted code mitigations. These are no longer enabled, so remove the code mitigation logic from the codebase. BUG=chromium:1003890 Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704 Commit-Queue: Ross McIlroy <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/master@{#76256} Refs: v8/v8@4ab70f6Fixes: nodejs#43296
Collaborator
nodejs-github-bot commented Jun 6, 2022
Review requested:
|
nodejs-github-bot added needs-ci 
bnoordhuis approved these changes Jun 6, 2022
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
RSLGTM. It's been broken for years (at least since 2020), maybe almost as long as it's been around.
gengjiawen approved these changes Jun 6, 2022
VoltrexKeyva approved these changes Jun 6, 2022
richardlau changed the title 
tniessen approved these changes Jun 11, 2022
Collaborator
nodejs-github-bot commented Jun 23, 2022
Collaborator
nodejs-github-bot commented Jun 23, 2022
Contributor
danielleadams commented Jun 26, 2022
Landed in f2dc43a |
danielleadams pushed a commit that referenced this pull request Jun 26, 2022
[Compiler] Remove untrusted code mitigations. These are no longer enabled, so remove the code mitigation logic from the codebase. BUG=chromium:1003890 Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704 Commit-Queue: Ross McIlroy <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/master@{#76256} Refs: v8/v8@4ab70f6Fixes: #43296 PR-URL: #43328 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
33 tasks
danielleadams pushed a commit that referenced this pull request Jul 7, 2022
[Compiler] Remove untrusted code mitigations. These are no longer enabled, so remove the code mitigation logic from the codebase. BUG=chromium:1003890 Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704 Commit-Queue: Ross McIlroy <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/master@{#76256} Refs: v8/v8@4ab70f6Fixes: #43296 PR-URL: #43328 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
[Compiler] Remove untrusted code mitigations. These are no longer enabled, so remove the code mitigation logic from the codebase. BUG=chromium:1003890 Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704 Commit-Queue: Ross McIlroy <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/master@{#76256} Refs: v8/v8@4ab70f6Fixes: nodejs/node#43296 PR-URL: nodejs/node#43328 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
davidjb added a commit to davidjb/isolated-vm that referenced this pull request Mar 7, 2024
This functionality was removed in Node 16.17.0 and 17.0.0. Comments on the relevant issues suggest this mitigations may never have worked: nodejs/node#43296nodejs/node#43328
laverdet pushed a commit to laverdet/isolated-vm that referenced this pull request Mar 7, 2024
This functionality was removed in Node 16.17.0 and 17.0.0. Comments on the relevant issues suggest this mitigations may never have worked: nodejs/node#43296nodejs/node#43328
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@4ab70f6
Fixes: #43296