tty: fix TypeError when stream is closed#43803
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci ContributorAuthor
aduh95 commented Aug 1, 2022
/cc @nodejs/tty |
joyeecheung approved these changes Aug 15, 2022
Collaborator
nodejs-github-bot commented Aug 15, 2022
Member
BridgeAR left a comment
BridgeAR left a comment There was a problem hiding this comment.
Is it useful to handle this gracefully? I would rather see an error that the stream is already destroyed? Otherwise it's difficult to know what happens as a user.
ContributorAuthor
aduh95 commented Aug 16, 2022
@BridgeAR see the linked issue, and I have also been annoyed by that error in other occasions. I struggled to find a good way to reproduce the error reliably, and I agree that the test as-is doesn't feel like something we would necessarily want to support, but the issue is real, and it looks like to me that fixing it is less problematic than not fixing it. |
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Aug 24, 2022
Landed in ab89024 |
sidwebworks pushed a commit to sidwebworks/node that referenced this pull request Aug 26, 2022
Fixes: nodejs#41330 PR-URL: nodejs#43803 Reviewed-By: Joyee Cheung <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
Fixes: #41330 PR-URL: #43803 Reviewed-By: Joyee Cheung <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
Fixes: nodejs#41330 PR-URL: nodejs#43803 Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Sep 16, 2022
Fixes: #41330 PR-URL: #43803 Reviewed-By: Joyee Cheung <[email protected]>
juanarbol pushed a commit that referenced this pull request Oct 10, 2022
Fixes: #41330 PR-URL: #43803 Reviewed-By: Joyee Cheung <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request Oct 11, 2022
Fixes: #41330 PR-URL: #43803 Reviewed-By: Joyee Cheung <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
Fixes: nodejs/node#41330 PR-URL: nodejs/node#43803 Reviewed-By: Joyee Cheung <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
Fixes: nodejs/node#41330 PR-URL: nodejs/node#43803 Reviewed-By: Joyee Cheung <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #41335 that got stalled.
Fixes: #41330