doc: copyedit releases.md#4384
Uh oh!
There was an error while loading. Please reload this page.
Conversation
jasnell commented Dec 22, 2015
LGTM |
doc/releases.md Outdated
There was a problem hiding this comment.
In general, I believe SCP is used for the protocol and scp for the command, similar to SSH vs. ssh. I'm fine with either here. No strong feelings either way.
There was a problem hiding this comment.
the intention was for it to refer to the command, if you do it as scp it should be clear
bnoordhuis commented Dec 22, 2015
LGTM |
1 similar comment
cjihrig commented Dec 22, 2015
LGTM |
rvagg commented Dec 23, 2015
Changes lgtm, thanks for the effort here @Trott. The doc is still out of date though, I'd love to go through and update it but I'm not sure I'll be able to find the time for a while. If any of the @nodejs/release team who have done a release recently want to have a go it'd be greatly appreciated. There are some things that stand out immediately:
I'm sure there are other things. |
Trott commented Dec 23, 2015
@rvagg Safe for me to interpret your comment as a wish list of updates you'd like to see someone do soon if someone knowledgable can get to it, but no reason to refrain from merging the changes that are here at this time? |
rvagg commented Dec 24, 2015
@Trott yes, that's correct, this lgtm as is for a simple copyedit, great job. |
PR-URL: nodejs#4384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Trott commented Dec 24, 2015
Landed in b094402 |
PR-URL: #4384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#4384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #4384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#4384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
6 participants
No description provided.