events: replace NodeCustomEvent with CustomEvent#43876
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jul 17, 2022
F3n67u added the events 
Member
benjamingr commented Jul 18, 2022
addaleax approved these changes Jul 19, 2022
| detail: kEnumerableProperty, | ||
| }); | ||
| classNodeCustomEventextendsEvent{ |
Member
There was a problem hiding this comment.
If you keep this as class NodeCustomEvent extends CustomEvent{}, that might even be a bit nicer since it’s a way to differentiate between events coming from a user and events coming from a Node.js EventEmitter .emit() call?
ContributorAuthor
There was a problem hiding this comment.
Could you help me understand what specific usercase do we need to support? I don't understand in which scenario we would need to differentiate between events coming from a user and events coming from a Node.js EventEmitter .emit() call.
aduh95 added the author ready Collaborator
nodejs-github-bot commented May 11, 2024
Contributor
aduh95 commented May 11, 2024
Landed in bd323b6 |
targos pushed a commit that referenced this pull request May 12, 2024
PR-URL: #43876 Refs: #43514 Reviewed-By: Anna Henningsen <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #43876 Refs: #43514 Reviewed-By: Anna Henningsen <[email protected]>
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #43876 Refs: #43514 Reviewed-By: Anna Henningsen <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #43876 Refs: #43514 Reviewed-By: Anna Henningsen <[email protected]>
ebouye pushed a commit to ebouye/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#43876 Refs: nodejs#43514 Reviewed-By: Anna Henningsen <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
PR-URL: nodejs#43876 Refs: nodejs#43514 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CustomEventis implemented at #43514,NodeCustomEventis the same asCustomEvent, so I replaceNodeCustomEventwithCustomEventin favor of web API. cc @daeyeonRefs: #43514 (comment)