https: use servername as agent key#4389
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
https requests with different SNI values should not be sent over the same connection, even if the `host` is the same. Server may want to present different certificate or route the incoming TLS connection differently, depending on the received servername extension. Fix: nodejs#3940
indutny added https 
MemberAuthor
indutny commented Dec 22, 2015
MemberAuthor
indutny commented Dec 22, 2015
cc @nodejs/crypto @nodejs/http @nodejs/collaborators |
Member
bnoordhuis commented Dec 22, 2015
LGTM but maybe write |
MemberAuthor
indutny commented Dec 22, 2015
Landed in 3213e5f, thank you! |
indutny added a commit that referenced this pull request Dec 22, 2015
https requests with different SNI values should not be sent over the same connection, even if the `host` is the same. Server may want to present different certificate or route the incoming TLS connection differently, depending on the received servername extension. Fix: #3940 PR-URL: #4389 Reviewed-By: Ben Noordhuis <[email protected]>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
https requests with different SNI values should not be sent over the same connection, even if the `host` is the same. Server may want to present different certificate or route the incoming TLS connection differently, depending on the received servername extension. Fix: nodejs#3940 PR-URL: nodejs#4389 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
https requests with different SNI values should not be sent over the same connection, even if the `host` is the same. Server may want to present different certificate or route the incoming TLS connection differently, depending on the received servername extension. Fix: #3940 PR-URL: #4389 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
https requests with different SNI values should not be sent over the same connection, even if the `host` is the same. Server may want to present different certificate or route the incoming TLS connection differently, depending on the received servername extension. Fix: #3940 PR-URL: #4389 Reviewed-By: Ben Noordhuis <[email protected]>
Merged
silverwind pushed a commit that referenced this pull request Jan 25, 2016
Add `servername` parameter docs for `https.request()` method. Follows #4389 PR-URL: #4729 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
rvagg pushed a commit that referenced this pull request Jan 26, 2016
Add `servername` parameter docs for `https.request()` method. Follows #4389 PR-URL: #4729 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
benjamingr pushed a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016
Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
Add `servername` parameter docs for `https.request()` method. Follows #4389 PR-URL: #4729 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
Add `servername` parameter docs for `https.request()` method. Follows #4389 PR-URL: #4729 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 13, 2016
Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
https requests with different SNI values should not be sent over the same connection, even if the `host` is the same. Server may want to present different certificate or route the incoming TLS connection differently, depending on the received servername extension. Fix: nodejs#3940 PR-URL: nodejs#4389 Reviewed-By: Ben Noordhuis <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https requests with different SNI values should not be sent over the
same connection, even if the
hostis the same. Server may want topresent different certificate or route the incoming TLS connection
differently, depending on the received servername extension.
Fix: #3940