New branch vee-eight-4.8#4399
Closed
New branch vee-eight-4.8 #4399
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
targos commented Dec 23, 2015
LGTM |
Member
targos commented Dec 23, 2015
ContributorAuthor
ofrobots commented Dec 25, 2015
ContributorAuthor
ofrobots commented Dec 25, 2015
Added a new commit to match the improved error message upon ArrayBuffer allocation failure. New CI: https://ci.nodejs.org/job/node-test-pull-request/1071/ looking green. @targos PTAL. /cc @skomski |
Member
targos commented Dec 26, 2015
LGTM |
Pick up V8 4.8 branch-head. This branch brings in @@isConcatSpreadable, @@toPrimitive and ToLength ES6 changes. For full details see: http://v8project.blogspot.de/2015/11/v8-release-48.html PR-URL: nodejs#4399 Reviewed-By: targos - Michaël Zasso <[email protected]>
Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{nodejs#31947} This postmortem information is useful for both object inspection, and function's context variables inspection. Ref: nodejs#3779 PR-URL: nodejs#4106 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: rvagg - Rod Vagg <[email protected]>
Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. [email protected],[email protected] NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{nodejs#31964} This adds some missing classes to postmortem info like JSMap and JSSet. Ref: nodejs#3792 PR-URL: nodejs#4106 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: rvagg - Rod Vagg <[email protected]>
The error message returned on ArrayBuffer allocation failure is now different as per https://codereview.chromium.org/1393263003. PR-URL: nodejs#4399 Reviewed-By: targos - Michaël Zasso <[email protected]>
ContributorAuthor
ofrobots commented Dec 27, 2015
Landed onto a new |
ofrobots added a commit to ofrobots/node that referenced this pull request Jan 4, 2016
The error message returned on ArrayBuffer allocation failure is now different as per https://codereview.chromium.org/1393263003. PR-URL: nodejs#4399 Reviewed-By: targos - Michaël Zasso <[email protected]>
ofrobots added a commit to ofrobots/node that referenced this pull request Jan 20, 2016
Pick up V8 4.8 branch-head. This branch brings in @@isConcatSpreadable, @@toPrimitive and ToLength ES6 changes. For full details see: http://v8project.blogspot.de/2015/11/v8-release-48.htmlv8/v8@fa163e2 Ref: nodejs#4399
ofrobots added a commit to ofrobots/node that referenced this pull request Jan 20, 2016
The error message returned on ArrayBuffer allocation failure is now different as per https://codereview.chromium.org/1393263003. Ref: nodejs#4399
ofrobots added a commit that referenced this pull request Jan 22, 2016
Pick up V8 4.8 branch-head. This branch brings in @@isConcatSpreadable, @@toPrimitive and ToLength ES6 changes. For full details see: http://v8project.blogspot.de/2015/11/v8-release-48.htmlv8/v8@fa163e2 Ref: #4399 PR-URL: #4785 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
ofrobots added a commit that referenced this pull request Jan 22, 2016
The error message returned on ArrayBuffer allocation failure is now different as per https://codereview.chromium.org/1393263003. Ref: #4399 PR-URL: #4785 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Pick up V8 4.8 branch-head. This branch brings in @@isConcatSpreadable, @@toPrimitive and ToLength ES6 changes. For full details see: http://v8project.blogspot.de/2015/11/v8-release-48.htmlv8/v8@fa163e2 Ref: nodejs#4399 PR-URL: nodejs#4785 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
The error message returned on ArrayBuffer allocation failure is now different as per https://codereview.chromium.org/1393263003. Ref: nodejs#4399 PR-URL: nodejs#4785 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not land on master
Pick up V8 4.8 into a new
vee-eight-4.8branch so that we can start testing with this V8 version. This branch brings in @@isConcatSpreadable, @@toPrimitive and ToLength ES6 changes. For full details see:http://v8project.blogspot.de/2015/11/v8-release-48.html
There are no API changes anticipated in this branch.
/cc @nodejs/v8