[v16.x backport] events: add CustomEvent#44082
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Aug 1, 2022
Review requested:
|
nodejs-github-bot added lib / src 
Member
targos commented Aug 1, 2022
Can you please rebase? I removed a7677bc from staging |
This implements the Web API `CustomEvent` in `internal/event_target`. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs#43514 Refs: nodejs#40678 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs#43885Fixes: nodejs#40678 Refs: nodejs#43514 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]>
aduh95force-pushed the backport-CustomEvent branch from 112b2a1 to 63c33e2Compare
Member
daeyeon commented Aug 2, 2022
@aduh95 Thanks for this backporting. |
Collaborator
nodejs-github-bot commented Aug 2, 2022
Collaborator
nodejs-github-bot commented Aug 2, 2022
targos approved these changes Aug 2, 2022
F3n67u approved these changes Aug 2, 2022
Member
targos commented Aug 2, 2022
Landed in a8c2418...7a5de2c |
targos pushed a commit that referenced this pull request Aug 2, 2022
This implements the Web API `CustomEvent` in `internal/event_target`. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43514 Backport-PR-URL: #44082 Refs: #40678 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Aug 2, 2022
Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43885 Backport-PR-URL: #44082Fixes: #40678 Refs: #43514 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]>
This was referenced Aug 3, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
This implements the Web API `CustomEvent` in `internal/event_target`. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs/node#43514 Backport-PR-URL: nodejs/node#44082 Refs: nodejs/node#40678 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs/node#43885 Backport-PR-URL: nodejs/node#44082Fixes: nodejs/node#40678 Refs: nodejs/node#43514 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of:
CustomEvent#43514CustomEventon the global scope via a CLI flag #43885