stream: update TextEncoderStream to align with the latest spec#44101
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
aduh95 reviewed Aug 2, 2022
lib/internal/webstreams/encoding.js Outdated
Comment on lines 6 to 7
| Uint8Array, | ||
| String |
Contributor
There was a problem hiding this comment.
Suggested change
| Uint8Array, | |
| String | |
| String, | |
| Uint8Array, |
benjamingr approved these changes Aug 2, 2022
cola119force-pushed the update-encoder-spec branch from f2304b6 to 03412dcCompare
aduh95 reviewed Aug 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
cola119force-pushed the update-encoder-spec branch from 03412dc to c44d983Compareaduh95 reviewed Aug 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
aduh95 approved these changes Aug 3, 2022
aduh95 added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Aug 3, 2022
Collaborator
nodejs-github-bot commented Aug 3, 2022
Collaborator
nodejs-github-bot commented Aug 4, 2022
aduh95 added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Aug 4, 2022
Landed in c8bea71 |
This was referenced Aug 5, 2022
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
PR-URL: #44101 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
PR-URL: #44101 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
PR-URL: nodejs#44101 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Member
juanarbol commented Sep 29, 2022
This is causing "wpt" tests in v16.x to fail. I will add the backport layer to this. |
cola119 changed the title Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updated
TextEncoderStreamimplementation to align with the latest WHATWG spec.transform(): https://encoding.spec.whatwg.org/#encode-and-enqueue-a-chunkflush: https://encoding.spec.whatwg.org/#encode-and-flushTest cases of
/test/fixtures/wpt/encoding/streams/encode-utf8.any.js(WPT forTextEncoderStream) are all passed now. (The previous implementation didn't support surrogate pairs.)