stream: improve view validation on ReadableStreamBYOBRequest.respondWithNewView()#44155
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
daeyeon changed the title ReadableStreamBYOBRequestReadableStreamBYOBRequest.respondWithNewView()
lpinca approved these changes Aug 6, 2022
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Aug 6, 2022
13 tasks
daeyeon added web streams request-ci github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Aug 7, 2022
daeyeon added the author ready 11 tasks
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Aug 8, 2022
This was referenced Aug 9, 2022
- This throws if the view is zero-length when there is an active reader when using `ReadableStreamBYOBRequest.respondWithNewView()`. - By doing that, we can get all tests passed in `readable-byte-streams/bad-buffers-and-views.any.js`. Signed-off-by: Daeyeon Jeong [email protected]
daeyeonforce-pushed the main.webstream-220806.Sat.5609 branch from d2b1fd7 to ee3507eCompare
MemberAuthor
daeyeon commented Aug 11, 2022
Rebased since |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Aug 11, 2022
lpinca added the commit-queue 
nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Aug 15, 2022
Commit Queue failed- Loading data for nodejs/node/pull/44155 ✔ Done loading data for nodejs/node/pull/44155 ----------------------------------- PR info ------------------------------------ Title stream: improve view validation on `ReadableStreamBYOBRequest.respondWithNewView()` (#44155) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch daeyeon:main.webstream-220806.Sat.5609 -> nodejs:main Labels author ready, needs-ci, web streams Commits 1 - stream: improve views validation on `BYOBRequest` Committers 1 - Daeyeon Jeong PR-URL: https://github.com/nodejs/node/pull/44155 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44155 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - stream: improve views validation on `BYOBRequest` ℹ This PR was created on Sat, 06 Aug 2022 17:16:39 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44155#pullrequestreview-1064334855 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-08-11T01:31:42Z: https://ci.nodejs.org/job/node-test-pull-request/45991/ - Querying data for job/node-test-pull-request/45991/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2862673144 |
lpinca approved these changes Aug 15, 2022
lpinca added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Aug 15, 2022
Landed in 46f6d22 |
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
- This throws if the view is zero-length when there is an active reader when using `ReadableStreamBYOBRequest.respondWithNewView()`. - By doing that, we can get all tests passed in `readable-byte-streams/bad-buffers-and-views.any.js`. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #44155 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view Reviewed-By: Luigi Pinca <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
- This throws if the view is zero-length when there is an active reader when using `ReadableStreamBYOBRequest.respondWithNewView()`. - By doing that, we can get all tests passed in `readable-byte-streams/bad-buffers-and-views.any.js`. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #44155 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view Reviewed-By: Luigi Pinca <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
- This throws if the view is zero-length when there is an active reader when using `ReadableStreamBYOBRequest.respondWithNewView()`. - By doing that, we can get all tests passed in `readable-byte-streams/bad-buffers-and-views.any.js`. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs#44155 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view Reviewed-By: Luigi Pinca <[email protected]>
Member
juanarbol commented Oct 3, 2022
Depends on #43455 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This throws if the view is zero-length when there is an active reader when using
ReadableStreamBYOBRequest.respondWithNewView().By doing that, we can get all tests passed in
wpt/streams/readable-byte-streams/bad-buffers-and-views.any.js.Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view
Signed-off-by: Daeyeon Jeong [email protected]