Skip to content

Conversation

@daeyeon
Copy link
Member

This doesn't include the other tests in the result when running a specific test in WPT.

The following is a result tested with #44234.

To-Be

$ node test/wpt/test-streams.js readable-byte-streams/bad-buffers-and-views.any.js[PASS] ReadableStream with byte source: reading into a zero-length view on a non-zero-length buffer rejects{ "readable-byte-streams/bad-buffers-and-views.any.js":{ "fail":{ "expected": [ "ReadableStream with byte source: respondWithNewView() throws if the supplied view's buffer is zero-length (in the readable state)" ] } }}Ran 1/1 tests, 0 skipped, 0 passed, 1 expected failures, 0 unexpected failures, 0 unexpected passes

As-Is

$ node test/wpt/test-streams.js readable-byte-streams/bad-buffers-and-views.any.js[PASS] ReadableStream with byte source: reading into a zero-length view on a non-zero-length buffer rejects{ "readable-byte-streams/bad-buffers-and-views.any.js":{ "fail":{ "expected": [ "ReadableStream with byte source: respondWithNewView() throws if the supplied view's buffer is zero-length (in the readable state)" ] } }}Ran 64/64 tests, 0 skipped, 63 passed, 1 expected failures, 0 unexpected failures, 7 unexpected passes/home/daeyeon/code/daeyeon.node/test/common/wpt.js:546 throw new Error( ^Error: Found 7 unexpected passes. Consider updating test/wpt/status/streams.json for these files:piping/abort.any.jsqueuing-strategies.any.jsreadable-byte-streams/general.any.jsreadable-byte-streams/tee.any.jsreadable-streams/default-reader.any.jsreadable-streams/templated.any.jswritable-streams/aborting.any.js at process.<anonymous> (/home/daeyeon/code/daeyeon.node/test/common/wpt.js:546:15) at process.emit (node:events:525:35)

Signed-off-by: Daeyeon Jeong [email protected]

This doesn't include the other tests for the result when running a specific test in WPT. Signed-off-by: Daeyeon Jeong [email protected]
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 14, 2022
@panvapanva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 14, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2022
@nodejs-github-bot
Copy link
Collaborator

@daeyeondaeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2022
@nodejs-github-botnodejs-github-bot merged commit a5d27f4 into nodejs:mainAug 26, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in a5d27f4

@daeyeondaeyeon deleted the main.wpt-runner-220815.Mon.52ac branch August 26, 2022 09:02
RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
This doesn't include the other tests for the result when running a specific test in WPT. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #44238 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Sep 5, 2022
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
This doesn't include the other tests for the result when running a specific test in WPT. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs#44238 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
@juanarbol
Copy link
Member

Depends on #43455

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@daeyeon@nodejs-github-bot@juanarbol@panva@antsmartian@lpinca