Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
tools: update doc to [email protected]#44370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
VoltrexKeyva approved these changes Aug 24, 2022
Trott approved these changes Aug 25, 2022
Member
Trott left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp LGTM
Contributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
CollaboratorAuthor
nodejs-github-bot commented Aug 25, 2022
This was referenced Aug 26, 2022
CollaboratorAuthor
nodejs-github-bot commented Aug 27, 2022
Commit Queue failed- Loading data for nodejs/node/pull/44370 ✔ Done loading data for nodejs/node/pull/44370 ----------------------------------- PR info ------------------------------------ Title tools: update doc to [email protected] (#44370) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-doc -> nodejs:main Labels doc, tools, author ready Commits 1 - tools: update doc to [email protected] Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 23 Aug 2022 21:26:40 GMT ✔ Approvals: 2 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44370#pullrequestreview-1083022482 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44370#pullrequestreview-1084665905 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2938807443 |
CollaboratorAuthor
nodejs-github-bot commented Aug 27, 2022
Commit Queue failed- Loading data for nodejs/node/pull/44370 ✔ Done loading data for nodejs/node/pull/44370 ----------------------------------- PR info ------------------------------------ Title tools: update doc to [email protected] (#44370) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-doc -> nodejs:main Labels doc, tools, author ready, commit-queue-failed Commits 1 - tools: update doc to [email protected] Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 23 Aug 2022 21:26:40 GMT ✔ Approvals: 2 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44370#pullrequestreview-1083022482 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44370#pullrequestreview-1084665905 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2939729472 |
CollaboratorAuthor
nodejs-github-bot commented Aug 27, 2022
30 tasks
CollaboratorAuthor
nodejs-github-bot commented Aug 28, 2022
Commit Queue failed- Loading data for nodejs/node/pull/44370 ✔ Done loading data for nodejs/node/pull/44370 ----------------------------------- PR info ------------------------------------ Title tools: update doc to [email protected] (#44370) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-doc -> nodejs:main Labels doc, tools, author ready, commit-queue-failed, commit-queue-squash Commits 2 - tools: update doc to [email protected] - tools: update doc to [email protected] Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: update doc to [email protected] ℹ This PR was created on Tue, 23 Aug 2022 21:26:40 GMT ✔ Approvals: 2 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44370#pullrequestreview-1083022482 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44370#pullrequestreview-1084665905 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2941244732 |
MoLow approved these changes Aug 28, 2022
CollaboratorAuthor
nodejs-github-bot commented Aug 28, 2022
Landed in be1b75b |
This was referenced Aug 29, 2022
RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
PR-URL: #44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
PR-URL: nodejs#44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos pushed a commit that referenced this pull request Sep 16, 2022
PR-URL: #44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
juanarbol pushed a commit that referenced this pull request Oct 10, 2022
PR-URL: #44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author readyPRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one. docIssues and PRs related to the documentations. toolsIssues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of doc to [email protected].