Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

This is an automated update of doc to [email protected].

@nodejs-github-botnodejs-github-bot added tools Issues and PRs related to the tools directory. doc Issues and PRs related to the documentations. labels Aug 23, 2022
Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@TrottTrott added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 25, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2022
@nodejs-github-bot
Copy link
CollaboratorAuthor

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 25, 2022
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Aug 27, 2022
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 27, 2022
@nodejs-github-bot
Copy link
CollaboratorAuthor

Commit Queue failed
- Loading data for nodejs/node/pull/44370 ✔ Done loading data for nodejs/node/pull/44370 ----------------------------------- PR info ------------------------------------ Title tools: update doc to [email protected] (#44370) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-doc -> nodejs:main Labels doc, tools, author ready Commits 1 - tools: update doc to [email protected] Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 23 Aug 2022 21:26:40 GMT ✔ Approvals: 2 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44370#pullrequestreview-1083022482 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44370#pullrequestreview-1084665905 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2938807443

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2022
@nodejs-github-bot
Copy link
CollaboratorAuthor

Commit Queue failed
- Loading data for nodejs/node/pull/44370 ✔ Done loading data for nodejs/node/pull/44370 ----------------------------------- PR info ------------------------------------ Title tools: update doc to [email protected] (#44370) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-doc -> nodejs:main Labels doc, tools, author ready, commit-queue-failed Commits 1 - tools: update doc to [email protected] Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 23 Aug 2022 21:26:40 GMT ✔ Approvals: 2 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44370#pullrequestreview-1083022482 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44370#pullrequestreview-1084665905 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2939729472

@nodejs-github-bot
Copy link
CollaboratorAuthor

@TrottTrott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 27, 2022
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 28, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 28, 2022
@nodejs-github-bot
Copy link
CollaboratorAuthor

Commit Queue failed
- Loading data for nodejs/node/pull/44370 ✔ Done loading data for nodejs/node/pull/44370 ----------------------------------- PR info ------------------------------------ Title tools: update doc to [email protected] (#44370) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-doc -> nodejs:main Labels doc, tools, author ready, commit-queue-failed, commit-queue-squash Commits 2 - tools: update doc to [email protected] - tools: update doc to [email protected] Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44370 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: update doc to [email protected] ℹ This PR was created on Tue, 23 Aug 2022 21:26:40 GMT ✔ Approvals: 2 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44370#pullrequestreview-1083022482 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44370#pullrequestreview-1084665905 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2941244732

@MoLowMoLow removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 28, 2022
@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 28, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 28, 2022
@nodejs-github-botnodejs-github-bot merged commit be1b75b into mainAug 28, 2022
@nodejs-github-botnodejs-github-bot deleted the actions/tools-update-doc branch August 28, 2022 06:21
@nodejs-github-bot
Copy link
CollaboratorAuthor

Landed in be1b75b

RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
PR-URL: #44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Sep 5, 2022
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
PR-URL: nodejs#44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos pushed a commit that referenced this pull request Sep 16, 2022
PR-URL: #44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
juanarbol pushed a commit that referenced this pull request Oct 10, 2022
PR-URL: #44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
@juanarboljuanarbol mentioned this pull request Oct 11, 2022
juanarbol pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44370 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@nodejs-github-bot@Trott@MoLow@VoltrexKeyva@aduh95