test: fix incorrect DNS cancel tests#44432
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
joyeecheung approved these changes Aug 30, 2022
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Sep 2, 2022
lpinca approved these changes Sep 4, 2022
Collaborator
nodejs-github-bot commented Sep 4, 2022
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Oct 28, 2022
This was referenced Oct 29, 2022
Collaborator
nodejs-github-bot commented Jan 18, 2023
This was referenced Jan 21, 2023
aduh95 added the author ready Collaborator
nodejs-github-bot commented May 11, 2024
Collaborator
nodejs-github-bot commented May 11, 2024
Contributor
aduh95 commented May 11, 2024
Landed in 8c0ec0f |
targos pushed a commit that referenced this pull request May 12, 2024
PR-URL: #44432 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #44432 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #44432 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #44432 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#44432 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
PR-URL: nodejs#44432 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#44428
Followup to #44022
Not sure what was I thinking at that moment, but calling
resolve411 times sends out 11 datagrams as expected, somustNotCallwas actually wrong.