bootstrap: remove unused global parameter in per-context scripts#44472
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Sep 1, 2022
Review requested:
|
nodejs-github-bot added c++ Collaborator
nodejs-github-bot commented Sep 1, 2022
legendecas approved these changes Sep 1, 2022
tniessen approved these changes Sep 1, 2022
addaleax approved these changes Sep 1, 2022
VoltrexKeyva approved these changes Sep 1, 2022
JungMinu approved these changes Sep 2, 2022
tniessen added author ready nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Sep 3, 2022
Commit Queue failed- Loading data for nodejs/node/pull/44472 ✔ Done loading data for nodejs/node/pull/44472 ----------------------------------- PR info ------------------------------------ Title bootstrap: remove unused global parameter in per-context scripts (#44472) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:remove-global -> nodejs:main Labels c++, author ready, needs-ci Commits 1 - bootstrap: remove unused global parameter in per-context scripts Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/44472 Reviewed-By: Chengzhong Wu Reviewed-By: Tobias Nießen Reviewed-By: Anna Henningsen Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Minwoo Jung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44472 Reviewed-By: Chengzhong Wu Reviewed-By: Tobias Nießen Reviewed-By: Anna Henningsen Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Minwoo Jung -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 01 Sep 2022 07:38:28 GMT ✔ Approvals: 5 ✔ - Chengzhong Wu (@legendecas): https://github.com/nodejs/node/pull/44472#pullrequestreview-1092944173 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44472#pullrequestreview-1092954123 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/44472#pullrequestreview-1093124829 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44472#pullrequestreview-1093152278 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/44472#pullrequestreview-1094185837 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-09-01T07:39:16Z: https://ci.nodejs.org/job/node-test-pull-request/46364/ - Querying data for job/node-test-pull-request/46364/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2983750891 |
joyeecheung added a commit that referenced this pull request Sep 6, 2022
PR-URL: #44472 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
MemberAuthor
joyeecheung commented Sep 6, 2022
Landed in addb726 |
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
PR-URL: nodejs#44472 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
PR-URL: #44472 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
PR-URL: #44472 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Member
juanarbol commented Oct 3, 2022
This breaks primordials in the v16.x release line |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.