Skip to content

tools: fix duration_ms to be milliseconds#44490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Mar 31, 2023
Merged

tools: fix duration_ms to be milliseconds #44490

nodejs-github-bot merged 1 commit into from
Mar 31, 2023

Conversation

@MoLow
Copy link
Member

@MoLowMoLow commented Sep 2, 2022•
edited by cclauss
Loading

I figured if we land #44450 (merged) it will be best to also fix it here.
this fix depends on nodejs/tap2junit#38 (merged)

@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Sep 2, 2022
@mscdexmscdex changed the title fix duration_ms to be millisecondstools: fix duration_ms to be millisecondsSep 2, 2022
@MoLowMoLow added the review wanted PRs that need reviews. label Sep 4, 2022
@MoLow
Copy link
MemberAuthor

MoLow commented Sep 5, 2022

@cclauss can you take a look at this and at nodejs/tap2junit#38 ?

@MoLowMoLow requested a review from aduh95September 5, 2022 14:56
aduh95
aduh95 reviewed Sep 6, 2022
View reviewed changes
@targostargos added blocked PRs that are blocked by other issues or PRs. lts-watch-v14.x labels Sep 6, 2022
@MoLowMoLow removed the review wanted PRs that need reviews. label Sep 11, 2022
@juanarboljuanarbol removed the blocked PRs that are blocked by other issues or PRs. label Oct 27, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 27, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47510/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 27, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 28, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47513/

@MoLow
Copy link
MemberAuthor

MoLow commented Oct 28, 2022

@juanarbol AFAIK this is still blocked due to nodejs/tap2junit#41

@MoLowMoLow added the blocked PRs that are blocked by other issues or PRs. label Oct 28, 2022
This was referenced Oct 29, 2022
Open
Open
Open
Open
@MoLowMoLow removed the blocked PRs that are blocked by other issues or PRs. label Mar 30, 2023
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 30, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50715/

@github-actionsgithub-actionsbot mentioned this pull request Mar 31, 2023
Open
34 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50726/

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-botnodejs-github-bot merged commit b541d2c into nodejs:mainMar 31, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2023

Landed in b541d2c

@MoLowMoLow deleted the fix-duration-ms branch March 31, 2023 12:25
This was referenced Apr 1, 2023
Open
Open
@RafaelGSSRafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@MoLow@RafaelGSS
tools: fix duration_ms to be milliseconds
e574827
PR-URL: #44490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Christian Clauss <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@MoLow@RafaelGSS
tools: fix duration_ms to be milliseconds
15e68fa
PR-URL: #44490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Christian Clauss <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@MoLow@RafaelGSS
tools: fix duration_ms to be milliseconds
8ad53a1
PR-URL: #44490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Christian Clauss <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@MoLow@RafaelGSS
tools: fix duration_ms to be milliseconds
03b6650
PR-URL: #44490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Christian Clauss <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow@danielleadams
tools: fix duration_ms to be milliseconds
6ab2215
PR-URL: #44490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Christian Clauss <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
@richardlaurichardlau mentioned this pull request Aug 24, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@himself65himself65himself65 approved these changes

@jasnelljasnelljasnell approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@cclausscclausscclauss approved these changes

@aduh95aduh95aduh95 approved these changes

@juanarboljuanarboljuanarbol approved these changes

@cjihrigcjihrigAwaiting requested review from cjihrig

@TrottTrottAwaiting requested review from Trott

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@MoLow@nodejs-github-bot@jasnell@benjamingr@cclauss@himself65@aduh95@juanarbol@targos