Skip to content

test_runner: add --test-name-pattern CLI flag#44508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cjihrig wants to merge 3 commits into from
Closed

test_runner: add --test-name-pattern CLI flag #44508

cjihrig wants to merge 3 commits into from

Conversation

@cjihrig
Copy link
Contributor

@cjihrigcjihrig commented Sep 3, 2022•
edited
Loading

This commit adds support for running tests that match a regular expression.

Fixes: #42984

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 3, 2022
MoLow
MoLow reviewed Sep 4, 2022
View reviewed changes
@MoLow
Copy link
Member

MoLow commented Sep 4, 2022•
edited
Loading

we will probably want to add this as an option to require('node:test').run, which can be part of a separate PR

@cjihrigcjihrig added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 5, 2022
MoLow
MoLow reviewed Oct 2, 2022
View reviewed changes
MoLow
MoLow reviewed Oct 2, 2022
View reviewed changes
MoLow
MoLow approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@MoLowMoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. added non-blocking comments

@cjihrig
test_runner: add --test-name-pattern CLI flag
20e8cf5
This commit adds support for running tests that match a regular expression. Fixes: nodejs#42984
@cjihrig
more tests more better
2ae9559
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 2, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47010/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 3, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47034/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 3, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47043/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 3, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47046/

@github-actionsgithub-actionsbot mentioned this pull request Oct 4, 2022
Open
16 tasks
@cjihrigcjihrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Oct 4, 2022
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 4, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 4, 2022

Commit Queue failed
- Loading data for nodejs/node/pull/44508 ✔ Done loading data for nodejs/node/pull/44508 ----------------------------------- PR info ------------------------------------ Title test_runner: add --test-name-pattern CLI flag (#44508) Author Colin Ihrig (@cjihrig) Branch cjihrig:test-name-pattern -> nodejs:main Labels c++, semver-minor, dont-land-on-v14.x, commit-queue-squash, test_runner Commits 3 - test_runner: add --test-name-pattern CLI flag - more tests more better - update node.1 Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/44508 Fixes: https://github.com/nodejs/node/issues/42984 Reviewed-By: Moshe Atlow Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44508 Fixes: https://github.com/nodejs/node/issues/42984 Reviewed-By: Moshe Atlow Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - update node.1 ℹ This PR was created on Sat, 03 Sep 2022 21:19:34 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/44508#pullrequestreview-1127666293 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44508#pullrequestreview-1127626541 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-03T19:38:53Z: https://ci.nodejs.org/job/node-test-pull-request/47046/ - Querying data for job/node-test-pull-request/47046/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3182397015

@cjihrig
Copy link
ContributorAuthor

cjihrig commented Oct 4, 2022

Landed in 87170c3

@cjihrigcjihrig closed this Oct 4, 2022
@cjihrigcjihrig deleted the test-name-pattern branch October 4, 2022 13:16
This was referenced Oct 5, 2022
Open
Open
Open
Open
Open
Open
@MoLowMoLow mentioned this pull request Nov 24, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@MoLowMoLowMoLow approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.semver-minorPRs that contain new features and should be released in the next minor version.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add command-line test filtering to node:test

4 participants

@cjihrig@MoLow@nodejs-github-bot@jasnell