Skip to content

dns: support dns module in the snapshot#44633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joyeecheung wants to merge 2 commits into from
Closed

dns: support dns module in the snapshot #44633

joyeecheung wants to merge 2 commits into from

Conversation

@joyeecheung
Copy link
Member

@joyeecheungjoyeecheung commented Sep 14, 2022

For the initial iteration, only the default resolver can be serialized/deserialized. If dns.setServers() has been called, we'll preserve the configured DNS servers in the snapshot. We can consider exposing the serialization method if it becomes necessary for user-land snapshots.

@joyeecheung
dns: support dns module in the snapshot
acbe447
For the initial iteration, only the default resolver can be serialized/deserialized. If `dns.setServers()` has been called, we'll preserve the configured DNS servers in the snapshot. We can consider exposing the serialization method if it becomes necessary for user-land snapshots.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 14, 2022

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 14, 2022
mcollina
mcollina approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgt

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 14, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46573/

aduh95
aduh95 reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@aduh95aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use trailing comma in all the multiline stuff.

This was referenced Sep 15, 2022
Open
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46674/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46815/

This was referenced Sep 27, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 28, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46891/

joyeecheung added a commit that referenced this pull request Sep 28, 2022
@joyeecheung
dns: support dns module in the snapshot
8821860
For the initial iteration, only the default resolver can be serialized/deserialized. If `dns.setServers()` has been called, we'll preserve the configured DNS servers in the snapshot. We can consider exposing the serialization method if it becomes necessary for user-land snapshots. PR-URL: #44633 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@joyeecheung
Copy link
MemberAuthor

joyeecheung commented Sep 28, 2022

Landed in 8821860

@github-actionsgithub-actionsbot mentioned this pull request Sep 29, 2022
Open
16 tasks
@juanarbol
Copy link
Member

juanarbol commented Oct 4, 2022

This depends on #44541; I will mark this as "backport-blocked-v16.x"

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@joyeecheung@danielleadams
dns: support dns module in the snapshot
9151439
For the initial iteration, only the default resolver can be serialized/deserialized. If `dns.setServers()` has been called, we'll preserve the configured DNS servers in the snapshot. We can consider exposing the serialization method if it becomes necessary for user-land snapshots. PR-URL: #44633 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Oct 11, 2022
Merged
@joyeecheungjoyeecheung mentioned this pull request Oct 12, 2022
Closed
codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2022
@codebytere
dns: support dns module in the snapshot
82914db
nodejs/node#44633#36118
jkleinsc added a commit to electron/electron that referenced this pull request Nov 21, 2022
@electron-roller@jkleinsc@codebytere
chore: bump node to v18.12.1 (main) (#36356)
c6d6af2
* chore: bump node in DEPS to v18.12.1 * chore: update patches * chore: add missing <algorithm> include * src: add detailed embedder process initialization AP nodejs/node#44121 * chore: update gn build files * dns: support dns module in the snapshot nodejs/node#44633#36118 * src: fix OOB reads in process.title getter nodejs/node#31633 * chore: fix incorrectly removed patch bit Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <[email protected]> Co-authored-by: Shelley Vohr <[email protected]>
tniessen added a commit to tniessen/node that referenced this pull request Feb 11, 2023
@tniessen
test: fix assertions in test-snapshot-dns-lookup*
765de7e
Due to the unfortunate nature of JavaScript, the extraneous arguments are silently ignored. In this case, the assertion trivially passes regardless of the given regular expressions. Refs: nodejs#44633
@tniessentniessen mentioned this pull request Feb 11, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Feb 18, 2023
@tniessen
test: fix assertions in test-snapshot-dns-lookup*
2472b67
Due to the unfortunate nature of JavaScript, the extraneous arguments are silently ignored. In this case, the assertion trivially passes regardless of the given regular expressions. Refs: #44633 PR-URL: #46618 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@tniessen@MylesBorins
test: fix assertions in test-snapshot-dns-lookup*
7606136
Due to the unfortunate nature of JavaScript, the extraneous arguments are silently ignored. In this case, the assertion trivially passes regardless of the given regular expressions. Refs: #44633 PR-URL: #46618 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
@tniessen@MylesBorins
test: fix assertions in test-snapshot-dns-lookup*
2239e24
Due to the unfortunate nature of JavaScript, the extraneous arguments are silently ignored. In this case, the assertion trivially passes regardless of the given regular expressions. Refs: #44633 PR-URL: #46618 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@electron-roller@jkleinsc
@codebytere@khalwa
chore: bump node to v18.12.1 (main) (electron#36356)
b077d85
* chore: bump node in DEPS to v18.12.1 * chore: update patches * chore: add missing <algorithm> include * src: add detailed embedder process initialization AP nodejs/node#44121 * chore: update gn build files * dns: support dns module in the snapshot nodejs/node#44633electron#36118 * src: fix OOB reads in process.title getter nodejs/node#31633 * chore: fix incorrectly removed patch bit Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <[email protected]> Co-authored-by: Shelley Vohr <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tniessen@danielleadams
test: fix assertions in test-snapshot-dns-lookup*
847d740
Due to the unfortunate nature of JavaScript, the extraneous arguments are silently ignored. In this case, the assertion trivially passes regardless of the given regular expressions. Refs: #44633 PR-URL: #46618 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung@nodejs-github-bot@juanarbol@mcollina@aduh95