Skip to content

test: use async/await in test-debugger-exceptions#44690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Sep 30, 2022
Merged

test: use async/await in test-debugger-exceptions #44690

nodejs-github-bot merged 1 commit into from
Sep 30, 2022

Conversation

@pete3249
Copy link
Contributor

@pete3249pete3249 commented Sep 16, 2022•
edited
Loading

Changes the promises to async/await in test/parallel/test-debugger-exceptions.js.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 16, 2022
@TrottTrott added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 16, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46631/

@TrottTrottforce-pushed the test-debugger-exceptions branch from af06765 to 700a062CompareSeptember 23, 2022 23:44
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
Trott
Trott reviewed Sep 23, 2022
View reviewed changes
Trott
Trott reviewed Sep 23, 2022
View reviewed changes
Trott
Trott reviewed Sep 23, 2022
View reviewed changes
@TrottTrott removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
Trott
Trott reviewed Sep 23, 2022
View reviewed changes
Trott
Trott reviewed Sep 23, 2022
View reviewed changes
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 23, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46737/

@github-actionsgithub-actionsbot mentioned this pull request Sep 26, 2022
Open
18 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 28, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46881/

@TrottTrottforce-pushed the test-debugger-exceptions branch from ddd830d to 6faf7d3CompareSeptember 28, 2022 01:45
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 28, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46882/

@TrottTrottforce-pushed the test-debugger-exceptions branch from 6faf7d3 to 9725a02CompareSeptember 28, 2022 01:53
@TrottTrott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 28, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 28, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46884/

@github-actionsgithub-actionsbot mentioned this pull request Sep 29, 2022
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 29, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46921/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 29, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46941/

@Trott
Copy link
Member

Trott commented Sep 29, 2022•
edited
Loading

Not sure why the test-worker-prof test is failing on Windows over and over on Jenkins, but I'll try rebasing and force pushing to hope it fixes it.

@TrottTrott changed the title src: change promises to async awaittest: change promises to async awaitSep 29, 2022
@TrottTrott changed the title test: change promises to async awaittest: use async/await in test-debugger-exceptionsSep 29, 2022
@TrottTrottforce-pushed the test-debugger-exceptions branch from 9725a02 to 97d60f9CompareSeptember 29, 2022 18:45
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 29, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/46945/

@github-actionsgithub-actionsbot mentioned this pull request Sep 30, 2022
Open
17 tasks
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2022
@nodejs-github-botnodejs-github-bot merged commit bf0c312 into nodejs:mainSep 30, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2022

Landed in bf0c312

@Trott
Copy link
Member

Trott commented Sep 30, 2022

Thanks for the contribution! 🎉

This was referenced Oct 1, 2022
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@pete3249@danielleadams
test: use async/await in test-debugger-exceptions
ee3c6a4
PR-URL: #44690 Reviewed-By: Rich Trott <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pete3249@nodejs-github-bot@Trott