Skip to content

http,http2: support more attributes for early hint link#44874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 14, 2022
Merged

http,http2: support more attributes for early hint link #44874

nodejs-github-bot merged 1 commit into from
Oct 14, 2022

Conversation

@anonrig
Copy link
Member

@anonriganonrig commented Oct 3, 2022

Link header should eventually have to support all attributes of the HTML link element.

Resolves#44843.
Dependent of #44820.

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 3, 2022
@anonriganonrig mentioned this pull request Oct 3, 2022
Merged
@zekth
Copy link

zekth commented Oct 3, 2022•
edited
Loading

Links in your issue are invalid

zekth
zekth reviewed Oct 3, 2022
View reviewed changes
@anonriganonrig changed the title lib: support more attributes for early hint linkhttp,http2: support more attributes for early hint linkOct 3, 2022
@ZYSzys
Copy link
Member

ZYSzys commented Oct 7, 2022

Can we add some tests ?

@anonriganonrigforce-pushed the feat/link-attributes branch from 4125c28 to 08bec68CompareOctober 7, 2022 11:22
@anonrig
Copy link
MemberAuthor

anonrig commented Oct 7, 2022

I added some tests. Thank you for the review @ZYSzys

@anonriganonrig requested a review from zekthOctober 9, 2022 18:43
@mcollinamcollina added http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 9, 2022
mcollina
mcollina approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 9, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47139/

@zekth
Copy link

zekth commented Oct 10, 2022

anonrig requested a review from zekth22 hours ago

I'm sorry i don't have permissions on this repo. But LGTM.

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 11, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47176/

@anonrig
Copy link
MemberAuthor

anonrig commented Oct 14, 2022

Can we get this through the finish line? @jasnell@mcollina

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 14, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 14, 2022
@nodejs-github-botnodejs-github-bot merged commit 2649aab into nodejs:mainOct 14, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 14, 2022

Landed in 2649aab

This was referenced Oct 17, 2022
Merged
Closed
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@anonrig@RafaelGSS
lib: support more attributes for early hint link
126d300
PR-URL: #44874 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@anonrig@RafaelGSS
lib: support more attributes for early hint link
8199841
PR-URL: #44874 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig@danielleadams
lib: support more attributes for early hint link
e02acea
PR-URL: #44874 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig@danielleadams
lib: support more attributes for early hint link
2375176
PR-URL: #44874 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@anonrig@danielleadams
lib: support more attributes for early hint link
f412834
PR-URL: #44874 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
@bnoordhuisbnoordhuis mentioned this pull request Feb 1, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@jasnelljasnelljasnell approved these changes

@zekthzekthAwaiting requested review from zekth

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.http2Issues or PRs related to the http2 subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

response.writeEarlyHints should support all link properties

6 participants

@anonrig@zekth@ZYSzys@nodejs-github-bot@mcollina@jasnell