Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
test_runner: add extra fields in AssertionError YAML#44952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
75c6a05 to 669a977CompareMoLow approved these changes Oct 10, 2022
Member
MoLow commented Oct 14, 2022
FYI @manekinekko let's make sure this addition is compatible with #43525 after it lands |
Contributor
manekinekko commented Oct 15, 2022
Yep, should be easy to add these fields here node/lib/internal/test_runner/tap_parser.js Lines 808 to 824 in 3b08f3c
|
Contributor
manekinekko commented Oct 16, 2022
Added in 26a2476 |
jasnell approved these changes Oct 16, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes.
669a977 to 6f09e43Compare This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Oct 25, 2022
Collaborator
nodejs-github-bot commented Oct 26, 2022
Commit Queue failed- Loading data for nodejs/node/pull/44952 ✔ Done loading data for nodejs/node/pull/44952 ----------------------------------- PR info ------------------------------------ Title test_runner: add extra fields in AssertionError YAML (#44952) Author Bryan English (@bengl) Branch bengl:bengl/expected-actual -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, test_runner Commits 1 - test_runner: add extra fields in AssertionError YAML Committers 1 - Bryan English PR-URL: https://github.com/nodejs/node/pull/44952 Reviewed-By: Moshe Atlow Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44952 Reviewed-By: Moshe Atlow Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test_runner: add extra fields in AssertionError YAML ℹ This PR was created on Mon, 10 Oct 2022 19:30:45 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/44952#pullrequestreview-1136519381 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44952#pullrequestreview-1143346750 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-25T12:38:51Z: https://ci.nodejs.org/job/node-test-pull-request/47465/ - Querying data for job/node-test-pull-request/47465/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3325742811 |
MoLow approved these changes Oct 26, 2022
Collaborator
nodejs-github-bot commented Oct 26, 2022
Landed in e260b37 |
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs#44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs#44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs#44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs/node#44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> (cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs/node#44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> (cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs/node#44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> (cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs/node#44952 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> (cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author readyPRs that have at least one approval, no pending requests for changes, and a CI started. needs-ciPRs that need a full CI run. test_runnerIssues and PRs related to the test runner subsystem.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many TAP reporters offer special-case handling of YAML objects containing
expected,actual, andoperatorfields, as produced byAssertionErrorand similar userland Error classes.