Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.4k
[v16.x backport] watch mode#44976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[v16.x backport] watch mode #44976
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
MoLow commented Oct 12, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as off-topic.
This comment was marked as off-topic.
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44366 Backport-PR-URL: nodejs#44976Fixes: nodejs#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44551 Backport-PR-URL: nodejs#44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44621 Backport-PR-URL: nodejs#44976Fixes: nodejs#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44739 Backport-PR-URL: nodejs#44976Fixes: nodejs#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
e3581a5 to cd3a54fCompareMoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44366 Backport-PR-URL: nodejs#44976Fixes: nodejs#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44551 Backport-PR-URL: nodejs#44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44621 Backport-PR-URL: nodejs#44976Fixes: nodejs#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44739 Backport-PR-URL: nodejs#44976Fixes: nodejs#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
cd3a54f to 72bf89eComparePR-URL: nodejs#44366 Backport-PR-URL: nodejs#44976Fixes: nodejs#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#44551 Backport-PR-URL: nodejs#44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
PR-URL: nodejs#44621 Backport-PR-URL: nodejs#44976Fixes: nodejs#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#44739 Backport-PR-URL: nodejs#44976Fixes: nodejs#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
72bf89e to d8f559eCompare This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
nodejs-github-bot commented Oct 13, 2022
danielleadams approved these changes Oct 14, 2022
JungMinu approved these changes Oct 17, 2022
MemberAuthor
MoLow commented Oct 29, 2022
@nodejs/releasers Hey, can this be merged in advance, a few days before the next node 16 release? #44873 depends on it |
richardlau pushed a commit that referenced this pull request Nov 23, 2022
PR-URL: #44366 Backport-PR-URL: #44976Fixes: #40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
PR-URL: #44551 Backport-PR-URL: #44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
PR-URL: #44621 Backport-PR-URL: #44976Fixes: #44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
PR-URL: #44739 Backport-PR-URL: #44976Fixes: #44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Member
richardlau commented Nov 23, 2022
Landed in 6f541d9...6d736a5 |
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44366 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44551 Backport-PR-URL: nodejs/node#44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44621 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44739 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44366 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44551 Backport-PR-URL: nodejs/node#44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44621 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44739 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits. lib / srcIssues and PRs related to general changes in the lib or src directory. needs-ciPRs that need a full CI run. watch-modeIssues and PRs related to watch mode
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of
#44366
#44551
#44621
#44739