Skip to content

Conversation

@MoLow
Copy link
Member

@MoLowMoLow commented Oct 12, 2022

@nodejs-github-bot

This comment was marked as off-topic.

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Oct 12, 2022
@MoLowMoLow added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 12, 2022
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44366 Backport-PR-URL: nodejs#44976Fixes: nodejs#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44551 Backport-PR-URL: nodejs#44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44621 Backport-PR-URL: nodejs#44976Fixes: nodejs#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44739 Backport-PR-URL: nodejs#44976Fixes: nodejs#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLowMoLowforce-pushed the backport-v16-watch-mode branch from e3581a5 to cd3a54fCompareOctober 12, 2022 09:29
@MoLowMoLow marked this pull request as ready for review October 12, 2022 09:31
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44366 Backport-PR-URL: nodejs#44976Fixes: nodejs#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44551 Backport-PR-URL: nodejs#44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44621 Backport-PR-URL: nodejs#44976Fixes: nodejs#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Oct 12, 2022
PR-URL: nodejs#44739 Backport-PR-URL: nodejs#44976Fixes: nodejs#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLowMoLowforce-pushed the backport-v16-watch-mode branch from cd3a54f to 72bf89eCompareOctober 12, 2022 16:22
PR-URL: nodejs#44366 Backport-PR-URL: nodejs#44976Fixes: nodejs#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#44551 Backport-PR-URL: nodejs#44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
PR-URL: nodejs#44621 Backport-PR-URL: nodejs#44976Fixes: nodejs#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#44739 Backport-PR-URL: nodejs#44976Fixes: nodejs#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLowMoLowforce-pushed the backport-v16-watch-mode branch from 72bf89e to d8f559eCompareOctober 12, 2022 19:44
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2022
@nodejs-github-bot

This comment was marked as off-topic.

@nodejs-github-bot
Copy link
Collaborator

@mfranzkemfranzke mentioned this pull request Oct 13, 2022
@MoLowMoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
@MoLow
Copy link
MemberAuthor

@nodejs/releasers Hey, can this be merged in advance, a few days before the next node 16 release? #44873 depends on it

richardlau pushed a commit that referenced this pull request Nov 23, 2022
PR-URL: #44366 Backport-PR-URL: #44976Fixes: #40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
PR-URL: #44551 Backport-PR-URL: #44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
PR-URL: #44621 Backport-PR-URL: #44976Fixes: #44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
PR-URL: #44739 Backport-PR-URL: #44976Fixes: #44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@richardlau
Copy link
Member

Landed in 6f541d9...6d736a5

@MoLowMoLow deleted the backport-v16-watch-mode branch November 23, 2022 22:06
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44366 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44551 Backport-PR-URL: nodejs/node#44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44621 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44739 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44366 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44551 Backport-PR-URL: nodejs/node#44976 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44621 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44739 Backport-PR-URL: nodejs/node#44976Fixes: nodejs/node#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.watch-modeIssues and PRs related to watch mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow@nodejs-github-bot@richardlau@JungMinu@danielleadams