Skip to content

fs: trace more fs api#45095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 26, 2022
Merged

fs: trace more fs api #45095

nodejs-github-bot merged 1 commit into from
Oct 26, 2022

Conversation

@theanarkh
Copy link
Contributor

@theanarkhtheanarkh commented Oct 20, 2022

trace more fs api.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Oct 20, 2022
@theanarkhtheanarkhforce-pushed the trace_more_fs_api branch 3 times, most recently from 11dcbf1 to 135a8b7CompareOctober 20, 2022 16:53
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022
anonrig
anonrig approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@anonriganonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 22, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47404/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 23, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47414/

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 23, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47430/

@theanarkh
Copy link
ContributorAuthor

theanarkh commented Oct 24, 2022

I have removed this test, it seems unstable.

This was referenced Oct 25, 2022
Open
Open
@theanarkhtheanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022
@nodejs-github-botnodejs-github-bot merged commit 775bf62 into nodejs:mainOct 26, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 26, 2022

Landed in 775bf62

This was referenced Oct 27, 2022
Open
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@theanarkh@RafaelGSS
fs: trace more fs api
bd68621
PR-URL: #45095 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@theanarkh@RafaelGSS
fs: trace more fs api
d89ca1b
PR-URL: #45095 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh@danielleadams
fs: trace more fs api
5d08f83
PR-URL: #45095 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh@danielleadams
fs: trace more fs api
b1f2031
PR-URL: #45095 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@theanarkh@danielleadams
fs: trace more fs api
da302ce
PR-URL: #45095 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes

@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theanarkh@nodejs-github-bot@anonrig@legendecas