test_runner: make sure tap subtest is reported in order#45220
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added dont-land-on-v14.x needs-ci 
MoLow commented Oct 28, 2022
| return; | ||
| } | ||
| this.#reportedSubtest =true; | ||
| this.parent.reportSubtest(); |
MoLow commented Oct 28, 2022
| @@ -0,0 +1,26 @@ | |||
| TAP version 13 | |||
MemberAuthor
There was a problem hiding this comment.
prior to the fix, output was
TAP version 13 # Subtest: nested # Subtest: nested ok 1 - nested --- duration_ms: 0.132417 ... # Subtest: nested - no tests 1..1 ok 1 - nested --- duration_ms: 0.740375 ... 1..1 ok 1 - nested - no tests --- duration_ms: 1.359792 ... 1..1 # tests 1 # pass 1 # fail 0 # cancelled 0 # skipped 0 # todo 0 # duration_ms 2.906166 
MemberAuthor
MoLow commented Oct 28, 2022
CC @nodejs/test_runner |
MoLow changed the title 
aduh95 reviewed Oct 28, 2022
Uh oh!
There was an error while loading. Please reload this page.
cjihrig approved these changes Oct 28, 2022
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM. This change is part of the TAP parser PR, right?
benjamingr approved these changes Oct 29, 2022
Co-authored-by: Antoine du Hamel <[email protected]>
MemberAuthor
MoLow commented Oct 29, 2022
the part seperating |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 29, 2022
MoLow added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Oct 30, 2022
Commit Queue failed- Loading data for nodejs/node/pull/45220 ✔ Done loading data for nodejs/node/pull/45220 ----------------------------------- PR info ------------------------------------ Title test_runner: make sure tap subtest is reported in order (#45220) Author Moshe Atlow (@MoLow) Branch MoLow:test_runner_fix_subtest -> nodejs:main Labels needs-ci, dont-land-on-v14.x, test_runner Commits 3 - test_runner: make sure tap subtest is reported by order - Update lib/internal/test_runner/test.js - fix Committers 2 - Moshe Atlow - GitHub PR-URL: https://github.com/nodejs/node/pull/45220 Reviewed-By: Colin Ihrig Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45220 Reviewed-By: Colin Ihrig Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - Update lib/internal/test_runner/test.js ⚠ - fix ℹ This PR was created on Fri, 28 Oct 2022 07:29:25 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45220#pullrequestreview-1160009419 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/45220#pullrequestreview-1161016247 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-29T18:39:28Z: https://ci.nodejs.org/job/node-test-pull-request/47559/ - Querying data for job/node-test-pull-request/47559/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3355445461 |
nodejs-github-bot added the commit-queue-failed MoLow removed the commit-queue-failed MoLow added a commit that referenced this pull request Oct 30, 2022
PR-URL: #45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MemberAuthor
MoLow commented Oct 30, 2022
Landed in 3e57891 |
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
PR-URL: #45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
PR-URL: #45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Nov 23, 2022
PR-URL: nodejs#45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Nov 23, 2022
PR-URL: nodejs#45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Dec 9, 2022
PR-URL: nodejs#45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
PR-URL: nodejs/node#45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> (cherry picked from commit 3e57891ee2fde0971e18fc383c25acf8f90def05)
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
PR-URL: nodejs/node#45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> (cherry picked from commit 3e57891ee2fde0971e18fc383c25acf8f90def05)
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
PR-URL: nodejs/node#45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> (cherry picked from commit 3e57891ee2fde0971e18fc383c25acf8f90def05)
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
PR-URL: nodejs/node#45220 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> (cherry picked from commit 3e57891ee2fde0971e18fc383c25acf8f90def05)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.