[v18.x] deps: patch V8 to 10.2.154.19#45229
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Oct 29, 2022
Review requested:
|
nodejs-github-bot added needs-ci 
targos added dont-land-on-v14.x request-ci 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Oct 29, 2022
Collaborator
nodejs-github-bot commented Oct 29, 2022
Collaborator
nodejs-github-bot commented Oct 29, 2022
This was referenced Oct 30, 2022
Collaborator
nodejs-github-bot commented Oct 31, 2022
Member
gengjiawen left a comment
gengjiawen left a comment There was a problem hiding this comment.
Looks you forget update common.gypi
MemberAuthor
@gengjiawen you mean the embedder string? We don't update it for official V8 patches, as they already change another part of the version string (V8_PATCH_LEVEL). |
gengjiawen approved these changes Oct 31, 2022
17 tasks
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 1, 2022
Collaborator
nodejs-github-bot commented Nov 1, 2022
Collaborator
nodejs-github-bot commented Nov 1, 2022
15 tasks
gengjiawen added the commit-queue targos removed the commit-queue targos added a commit that referenced this pull request Nov 5, 2022
Refs: v8/v8@10.2.154.15...10.2.154.19 PR-URL: #45229 Reviewed-By: Jiawen Geng <[email protected]>
MemberAuthor
targos commented Nov 5, 2022
Landed in 2e621c3 |
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Refs: v8/v8@10.2.154.15...10.2.154.19 PR-URL: #45229 Reviewed-By: Jiawen Geng <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@10.2.154.15...10.2.154.19