Skip to content

src: resolve TODO related to inspector CVEs#45341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 6, 2022
Merged

src: resolve TODO related to inspector CVEs #45341

nodejs-github-bot merged 1 commit into from
Nov 6, 2022

Conversation

@tniessen
Copy link
Member

@tniessentniessen commented Nov 6, 2022

This was not done before the security release because the latest CVE was not known at the time.

@tniessen
src: resolve TODO related to inspector CVEs
b291118
This was not done before the security release because the latest CVE was not known at the time.
@tniessentniessen added security Issues and PRs related to security. inspector Issues and PRs related to the V8 inspector protocol labels Nov 6, 2022
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 6, 2022
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2022
@github-actions
Copy link
Contributor

github-actionsbot commented Nov 6, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 6, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47740/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 6, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47745/

@tniessentniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 6, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2022
@nodejs-github-botnodejs-github-bot merged commit 7903f94 into nodejs:mainNov 6, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 6, 2022

Landed in 7903f94

This was referenced Nov 7, 2022
Open
Open
Open
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
@tniessen
src: resolve TODO related to inspector CVEs
5e90a13
This was not done before the security release because the latest CVE was not known at the time. PR-URL: nodejs#45341 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 10, 2022
Open
20 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@tniessen@RafaelGSS
src: resolve TODO related to inspector CVEs
326d19a
This was not done before the security release because the latest CVE was not known at the time. PR-URL: #45341 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Nov 10, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@tniessen@danielleadams
src: resolve TODO related to inspector CVEs
9314d09
This was not done before the security release because the latest CVE was not known at the time. PR-URL: #45341 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@tniessen@danielleadams
src: resolve TODO related to inspector CVEs
9c23dab
This was not done before the security release because the latest CVE was not known at the time. PR-URL: #45341 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@tniessen@danielleadams
src: resolve TODO related to inspector CVEs
89b3336
This was not done before the security release because the latest CVE was not known at the time. PR-URL: #45341 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@tniessen@danielleadams
src: resolve TODO related to inspector CVEs
c66ae82
This was not done before the security release because the latest CVE was not known at the time. PR-URL: #45341 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@anonriganonriganonrig approved these changes

@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fast-trackPRs that do not need to wait for 48 hours to land.inspectorIssues and PRs related to the V8 inspector protocolneeds-ciPRs that need a full CI run.securityIssues and PRs related to security.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen@nodejs-github-bot@Trott@anonrig@BridgeAR