lib: do not throw if global property is no longer configurable#45344
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 6, 2022
Review requested:
|
joyeecheung approved these changes Nov 7, 2022
ljharb approved these changes Nov 7, 2022
GeoffreyBooth approved these changes Nov 7, 2022
aduh95 added author ready 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 7, 2022
MrJithil reviewed Nov 8, 2022
| // Disable the current getter/setter and set up a new | ||
| // non-enumerable property. | ||
| deleteobject[name]; |
Member
There was a problem hiding this comment.
Hope this is line of code not needed anymore.
JakobJingleheimer approved these changes Nov 8, 2022
Collaborator
nodejs-github-bot commented Nov 8, 2022
This was referenced Nov 11, 2022
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 15, 2022
jasnell approved these changes Nov 16, 2022
Collaborator
nodejs-github-bot commented Nov 17, 2022
joyeecheung added commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 17, 2022
Landed in a65a9d1 |
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
Fixes: #45336 PR-URL: #45344 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
Fixes: nodejs#45336 PR-URL: nodejs#45344 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Fixes: #45336 PR-URL: #45344 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Fixes: #45336 PR-URL: #45344 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Fixes: #45336 PR-URL: #45344 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
Fixes: #45336 PR-URL: #45344 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #45336