build: arm64 cross-compile time improvement#45432
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 11, 2022
Review requested:
|
nodejs-github-bot added build 
Member
It seems this is a total revert. If so, can you please use |
Contributor
niyas-sait commented Nov 12, 2022
LGTM |
lpinca approved these changes Nov 12, 2022
anonrig requested changes Nov 12, 2022
Uh oh!
There was an error while loading. Please reload this page.
StefanStojanovicforce-pushed the mefi-arm64-build branch from cf58fcc to f268f3aCompare
anonrig approved these changes Nov 12, 2022
Trott approved these changes Nov 12, 2022
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Nov 12, 2022
Collaborator
nodejs-github-bot commented Nov 12, 2022
Collaborator
nodejs-github-bot commented Nov 12, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer).
StefanStojanovicforce-pushed the mefi-arm64-build branch from f268f3a to ffefa89CompareContributorAuthor
StefanStojanovic commented Nov 13, 2022
@lpinca I've missed your comment previously. Anyway, you are correct it is a total revert and I made changes to my commit as suggested. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 14, 2022
Collaborator
nodejs-github-bot commented Nov 14, 2022
Collaborator
nodejs-github-bot commented Nov 14, 2022
Collaborator
nodejs-github-bot commented Nov 14, 2022
sxa approved these changes Nov 15, 2022
Collaborator
nodejs-github-bot commented Nov 15, 2022
This was referenced Nov 16, 2022
Collaborator
nodejs-github-bot commented Nov 17, 2022
12 tasks
ContributorAuthor
StefanStojanovic commented Nov 18, 2022
These CI errors seem unrelated to my change. Is there something I can do to help move this forward? |
Collaborator
nodejs-github-bot commented Nov 18, 2022
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 18, 2022
Landed in 1f63c95 |
This was referenced Nov 19, 2022
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
15 tasks
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: nodejs#45432 Refs: nodejs#42538 Refs: nodejs#42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
…st builds" This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be observed on Jenkins, that Windows ARM64 build times of Node v14 and the latest version differ very much (v14 is built 3 times faster than the current version). After bisecting commits, I've found out that this change introduced that compilation time increment. I've reverted this change and tested cross-compilation locally and I didn't encounter any problems. As a result, I'm opening this PR to see if the results will be the same in the CI.
@nsait-linaro @targos I'm tagging the two of you for visibility because you've opened the original PR and approved it respectively.
Refs: #42538
Refs: #42375