test: remove flaky designation for test-worker-http2-stream-terminate#45438
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
github-actionsbot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Nov 12, 2022
MemberAuthor
Trott commented Nov 12, 2022
Stress test suggests this isn't flaky anymore, so I'm going to move this out of draft mode. |
25 tasks
Trott added the author ready 
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Nov 13, 2022
lpinca approved these changes Nov 13, 2022
Trott added the commit-queue 25 tasks
Contributor
ywave620 commented Nov 14, 2022
Should we move this test back to parallel? I checked the CI history, after this test is moved to sequential, it has reliably paased in the last few months. |
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 14, 2022
Landed in badc631 |
This was referenced Nov 15, 2022
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
Closes: #43084 PR-URL: #45438Fixes: #43084 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Closes: #43084 PR-URL: #45438Fixes: #43084 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Closes: #43084 PR-URL: #45438Fixes: #43084 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Closes: #43084 PR-URL: #45438Fixes: #43084 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
Closes: #43084 PR-URL: #45438Fixes: #43084 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #43084