Skip to content

src: don't run tasks on isolate termination#45444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 17, 2022
Merged

src: don't run tasks on isolate termination #45444

nodejs-github-bot merged 1 commit into from
Nov 17, 2022

Conversation

@santigimeno
Copy link
Member

@santigimenosantigimeno commented Nov 13, 2022

Fixes: #45419

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 13, 2022
@Trott
Copy link
Member

Trott commented Nov 13, 2022

Is it reasonable to add a test for this?

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 13, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47910/

This was referenced Nov 14, 2022
Open
Open
Open
@github-actionsgithub-actionsbot mentioned this pull request Nov 17, 2022
Open
13 tasks
@santigimeno
Copy link
MemberAuthor

santigimeno commented Nov 17, 2022

Is it reasonable to add a test for this?

I'd love to, but it's not really straightforward. If someone wants to take the undici test and strip it down to a basic reproducer, it'd be great.

@santigimenosantigimeno added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47980/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47994/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2022
@nodejs-github-botnodejs-github-bot merged commit b18ec04 into nodejs:mainNov 17, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2022

Landed in b18ec04

This was referenced Nov 18, 2022
Open
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@santigimeno@ruyadorno
src: don't run tasks on isolate termination
5e5bf0c
Fixes: #45419 PR-URL: #45444 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 22, 2022
Open
15 tasks
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@santigimeno@marco-ippolito
src: don't run tasks on isolate termination
3f0e136
Fixes: nodejs#45419 PR-URL: nodejs#45444 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@ruyadornoruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@santigimeno@danielleadams
src: don't run tasks on isolate termination
dfddaa5
Fixes: #45419 PR-URL: #45444 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@santigimeno@danielleadams
src: don't run tasks on isolate termination
e343511
Fixes: #45419 PR-URL: #45444 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@santigimeno@danielleadams
src: don't run tasks on isolate termination
2c6a4fd
Fixes: #45419 PR-URL: #45444 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@santigimeno@danielleadams
src: don't run tasks on isolate termination
8874833
Fixes: #45419 PR-URL: #45444 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crash when running undici's wpt runner in node v19

6 participants

@santigimeno@Trott@nodejs-github-bot@bnoordhuis@jasnell@lpinca