Skip to content

benchmark: add text-encoder benchmark#45450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 18, 2022
Merged

benchmark: add text-encoder benchmark #45450

nodejs-github-bot merged 1 commit into from
Nov 18, 2022

Conversation

@anonrig
Copy link
Member

@anonriganonrig commented Nov 13, 2022

No description provided.

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Nov 13, 2022
mscdex
mscdex reviewed Nov 13, 2022
View reviewed changes
@anonriganonrigforce-pushed the benchmark/text-encoder branch from fbe8351 to 8f787c6CompareNovember 13, 2022 19:52
@anonriganonrig added performance Issues and PRs related to the performance of Node.js. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 13, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 13, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47914/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 14, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47916/

@aduh95
Copy link
Contributor

aduh95 commented Nov 14, 2022

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1220/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 14, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47927/

Qard
Qard approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@QardQard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small suggestion

@anonriganonrigforce-pushed the benchmark/text-encoder branch from 8f787c6 to 4f9fce7CompareNovember 15, 2022 14:26
@anonriganonrig requested a review from QardNovember 15, 2022 14:27
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 15, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 15, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47948/

jasnell
jasnell reviewed Nov 16, 2022
View reviewed changes
@anonriganonrigforce-pushed the benchmark/text-encoder branch from 4f9fce7 to bb344f1CompareNovember 17, 2022 13:59
@anonriganonrig requested review from Qard and jasnellNovember 17, 2022 13:59
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47987/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2022
@nodejs-github-botnodejs-github-bot merged commit cb96a13 into mainNov 18, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 18, 2022

Landed in cb96a13

@nodejs-github-botnodejs-github-bot deleted the benchmark/text-encoder branch November 18, 2022 19:48
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@anonrig@ruyadorno
benchmark: add text-encoder benchmark
26ad54c
PR-URL: #45450 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@anonrig@marco-ippolito
benchmark: add text-encoder benchmark
639e5e2
PR-URL: nodejs#45450 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@ruyadornoruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig@danielleadams
benchmark: add text-encoder benchmark
98dfc29
PR-URL: #45450 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig@danielleadams
benchmark: add text-encoder benchmark
b0c42b0
PR-URL: #45450 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@anonrig@danielleadams
benchmark: add text-encoder benchmark
fcf6188
PR-URL: #45450 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@anonrig@danielleadams
benchmark: add text-encoder benchmark
4459178
PR-URL: #45450 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@anonrig@danielleadams
benchmark: add text-encoder benchmark
ec7ef3c
PR-URL: #45450 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes

@lpincalpincalpinca approved these changes

@jasnelljasnellAwaiting requested review from jasnell

+1 more reviewer

@mscdexmscdexmscdex left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.performanceIssues and PRs related to the performance of Node.js.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@anonrig@nodejs-github-bot@aduh95@mscdex@Qard@jasnell@lpinca