deps: patch V8 to 10.7.193.22#45460
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 14, 2022
Review requested:
|
nodejs-github-bot added needs-ci 
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aduh95 approved these changes Nov 14, 2022
Member
anonrig commented Nov 15, 2022
@targos What is your timeline/thoughts for upgrading v8 11? |
Member
Trott commented Nov 15, 2022
You'll need to rebase against the main branch to pick up the fix for the lint issue. |
gengjiawen approved these changes Nov 15, 2022
MemberAuthor
targos commented Nov 15, 2022
Rebased |
MemberAuthor
targos commented Nov 15, 2022
@anonrig Whenever it's ready. Note that there's nothing special to expect with V8 11.0 compared to other versions. V8 version numbers don't follow semver, they follow the Chromium schedule. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 15, 2022
Collaborator
nodejs-github-bot commented Nov 15, 2022
Collaborator
nodejs-github-bot commented Nov 15, 2022
Member
gengjiawen commented Nov 15, 2022
You can try latest v8 bundled in node in https://github.com/nodejs/node-v8/tree/canary. |
anonrig approved these changes Nov 15, 2022
Collaborator
nodejs-github-bot commented Nov 15, 2022
Collaborator
nodejs-github-bot commented Nov 16, 2022
targos added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 16, 2022
Landed in 8f9dc27 |
This was referenced Nov 20, 2022
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
Refs: v8/v8@10.7.193.20...10.7.193.22 PR-URL: #45460 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@10.7.193.20...10.7.193.22