Skip to content

Conversation

@RafaelGSS
Copy link
Member

@RafaelGSSRafaelGSS commented Nov 14, 2022

It was missed in the last release

cc: @nodejs/releasers

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 14, 2022
@richardlaurichardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@RafaelGSS
Copy link
MemberAuthor

@richardlau probably the lint error should be ignored, right?

@aduh95
Copy link
Contributor

@richardlau probably the lint error should be ignored, right?

It should be fixed, really. Working on a PR.

@RafaelGSS
Copy link
MemberAuthor

@aduh95 Does it need to wait #45463 to land?

@RafaelGSSRafaelGSS mentioned this pull request Nov 14, 2022
It was missed in the last release. Refs: nodejs@3770d3a
@aduh95aduh95force-pushed the include-v19.1.0-changelog branch from d2db6dc to 08c2d43CompareNovember 15, 2022 00:52
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2022
@nodejs-github-botnodejs-github-bot merged commit 0a592e4 into nodejs:mainNov 15, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 0a592e4

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
It was missed in the last release. Refs: 3770d3a PR-URL: #45462 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadornoruyadorno mentioned this pull request Nov 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@RafaelGSS@aduh95@nodejs-github-bot@ruyadorno@Trott@lpinca@anonrig@richardlau@BethGriggs@HarshithaKP@danielleadams