Skip to content

Conversation

@panva
Copy link
Member

Fixes: #45485

@panvapanva added crypto Issues and PRs related to the crypto subsystem. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 17, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 17, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot

This comment was marked as outdated.

@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2022
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2022
@panvapanva requested a review from anonrigNovember 18, 2022 05:15
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2022
@nodejs-github-botnodejs-github-bot merged commit b61603f into nodejs:mainNov 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in b61603f

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@ruyadornoruyadorno mentioned this pull request Nov 24, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panvapanva deleted the crypto-fix-45485 branch January 2, 2023 22:07
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
m0th3rch1p pushed a commit to m0th3rch1p/node that referenced this pull request Jul 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crypto: X509Certificate.checkPrivateKey() used with a non-matching key makes the next call to createPrivateKey() fail.

4 participants

@panva@nodejs-github-bot@anonrig@tniessen