Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
crypto: clear OpenSSL error queue after calling X509_check_private_key()#45495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 17, 2022
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
tniessen approved these changes Nov 17, 2022
This comment was marked as outdated.
This comment was marked as outdated.
anonrig approved these changes Nov 17, 2022
Collaborator
nodejs-github-bot commented Nov 17, 2022
12 tasks
anonrig approved these changes Nov 18, 2022
Collaborator
nodejs-github-bot commented Nov 19, 2022
Landed in b61603f |
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
Fixes: #45485 PR-URL: #45495 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
Fixes: nodejs#45485 PR-URL: nodejs#45495 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Fixes: #45485 PR-URL: #45495 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Fixes: #45485 PR-URL: #45495 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Fixes: #45485 PR-URL: #45495 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
Fixes: #45485 PR-URL: #45495 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
Fixes: #45485 PR-URL: #45495 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
oraluben pushed a commit to oraluben/node that referenced this pull request Mar 14, 2023
Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/375 CVE-ID: CVE-2023-23919Fixes: nodejs/node#45485 PR-URL: nodejs/node#45495 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1808596 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
oraluben pushed a commit to oraluben/node that referenced this pull request Mar 17, 2023
Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/375 CVE-ID: CVE-2023-23919Fixes: nodejs/node#45485 PR-URL: nodejs/node#45495 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1808596 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
m0th3rch1p pushed a commit to m0th3rch1p/node that referenced this pull request Jul 20, 2025
Backport-PR-URL: nodejs-private/node-private#375 CVE-ID: CVE-2023-23919Fixes: nodejs#45485 PR-URL: nodejs#45495 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1808596 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author readyPRs that have at least one approval, no pending requests for changes, and a CI started. c++Issues and PRs that require attention from people who are familiar with C++. cryptoIssues and PRs related to the crypto subsystem. needs-ciPRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #45485