Revert "url: improve port validation"#45517
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 5f7730e. This change broke too many edge cases in the ecosystem. Reverting it re-introduces some host-spoofing possibilities, so we won't want to revert forever, but the issue is long-lived enough and not sufficiently critical that we can't wait for a major release to introduce it as a breaking change. After this lands, I plan to re-introduce this as a change that throws a warning rather than an error, after which we can land a semver-major that re-introduces the error and try to get the word out to maintainers of likely-affected packages. Closes: nodejs#45514 Refs: nodejs#45012
nodejs-github-bot added needs-ci 
MemberAuthor
Trott commented Nov 19, 2022
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Nov 19, 2022
jasnell approved these changes Nov 19, 2022
richardlau approved these changes Nov 19, 2022
Member
richardlau commented Nov 19, 2022
Since this is a revert, setting the same don't-land labels as #45012. |
ljharb approved these changes Nov 19, 2022
Member
ljharb commented Nov 19, 2022
Thanks! |
Collaborator
nodejs-github-bot commented Nov 19, 2022
Trott added author ready 
anonrig approved these changes Nov 19, 2022
Contributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 19, 2022
Commit Queue failed- Loading data for nodejs/node/pull/45517 ✔ Done loading data for nodejs/node/pull/45517 ----------------------------------- PR info ------------------------------------ Title Revert "url: improve port validation" (#45517) Author Rich Trott (@Trott) Branch Trott:revert-it -> nodejs:main Labels url, fast-track, author ready, needs-ci, dont-land-on-v14.x, dont-land-on-v16.x, dont-land-on-v18.x Commits 1 - Revert "url: improve port validation" Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/45517 Fixes: https://github.com/nodejs/node/issues/45514 Refs: https://github.com/nodejs/node/pull/45012 Reviewed-By: James M Snell Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45517 Fixes: https://github.com/nodejs/node/issues/45514 Refs: https://github.com/nodejs/node/pull/45012 Reviewed-By: James M Snell Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 19 Nov 2022 14:23:45 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45517#pullrequestreview-1187082412 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45517#pullrequestreview-1187082570 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45517#pullrequestreview-1187100493 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-11-19T15:29:52Z: https://ci.nodejs.org/job/node-test-pull-request/48018/ - Querying data for job/node-test-pull-request/48018/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3504637731 |
nodejs-github-bot added the commit-queue-failed 
aduh95 approved these changes Nov 19, 2022
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 19, 2022
Landed in bd965aa |
This was referenced Nov 20, 2022
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
This reverts commit 5f7730e. This change broke too many edge cases in the ecosystem. Reverting it re-introduces some host-spoofing possibilities, so we won't want to revert forever, but the issue is long-lived enough and not sufficiently critical that we can't wait for a major release to introduce it as a breaking change. After this lands, I plan to re-introduce this as a change that throws a warning rather than an error, after which we can land a semver-major that re-introduces the error and try to get the word out to maintainers of likely-affected packages. Closes: #45514 Refs: #45012 PR-URL: #45517Fixes: #45514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This was referenced Nov 22, 2022
4 tasks
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
This reverts commit 5f7730e. This change broke too many edge cases in the ecosystem. Reverting it re-introduces some host-spoofing possibilities, so we won't want to revert forever, but the issue is long-lived enough and not sufficiently critical that we can't wait for a major release to introduce it as a breaking change. After this lands, I plan to re-introduce this as a change that throws a warning rather than an error, after which we can land a semver-major that re-introduces the error and try to get the word out to maintainers of likely-affected packages. Closes: nodejs#45514 Refs: nodejs#45012 PR-URL: nodejs#45517Fixes: nodejs#45514 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5f7730e.
This change broke too many edge cases in the ecosystem. Reverting it re-introduces some host-spoofing possibilities, so we won't want to revert forever, but the issue has been around for a long time and we can wait for a major release to introduce the fix as a breaking change. After this lands, I plan to re-introduce this as a change that throws a warning rather than an error, after which we can land a semver-major that re-introduces the error and try to get the word out to maintainers of likely-affected packages.
Closes: #45514
Refs: #45012