Skip to content

lib: improve AbortController creation duration#45525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anonrig wants to merge 2 commits into from
Closed

lib: improve AbortController creation duration #45525

anonrig wants to merge 2 commits into from

Conversation

@anonrig
Copy link
Member

@anonriganonrig commented Nov 19, 2022

  1. Remove createAbortSignal() call unless signal getter is called.
  2. Improve kMakeTransferable abort signal creation.

@anonriganonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Nov 19, 2022
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 19, 2022
@anonriganonrig changed the title Stream/abort controllerlib: improve AbortController creation durationNov 19, 2022
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 19, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48026/

mcollina
mcollina approved these changes Nov 19, 2022
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Are we gaining any perf?

@anonrig
Copy link
MemberAuthor

anonrig commented Nov 19, 2022

Are we gaining any perf?

For certain paths, 100% sure. But I am not sure with benchmark is more appropriate for this change. Any recommendations @mcollina?

@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2022
aduh95
aduh95 reviewed Nov 19, 2022
View reviewed changes
@aduh95aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2022
@anonriganonrigforce-pushed the stream/abort-controller branch 2 times, most recently from bef645b to c2b464bCompareNovember 19, 2022 21:32
aduh95
aduh95 reviewed Nov 19, 2022
View reviewed changes
@anonriganonrigforce-pushed the stream/abort-controller branch from c2b464b to 34489feCompareNovember 19, 2022 22:17
@anonriganonrig requested a review from aduh95November 19, 2022 22:22
@anonrig
Copy link
MemberAuthor

anonrig commented Nov 19, 2022

@aduh95@mcollina Can you review it again, please?

@aduh95
Copy link
Contributor

aduh95 commented Nov 19, 2022

Don't hesitate to use fixup commits (i.e. git commit --fixup) to avoid force-pushing, as force pushing doesn't make a great reviewing experience (and our tooling can perfectly handle fixup commits).

@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 19, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 19, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48029/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48032/

@anonriganonrig added the performance Issues and PRs related to the performance of Node.js. label Nov 20, 2022
mcollina
mcollina approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2022
@github-actionsgithub-actionsbot mentioned this pull request Nov 21, 2022
Open
15 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2022

Landed in b4666c3...367ac71

nodejs-github-bot pushed a commit that referenced this pull request Nov 21, 2022
@anonrig@nodejs-github-bot
lib: improve AbortController creation duration
5fe7003
PR-URL: #45525 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Nov 21, 2022
@anonrig@nodejs-github-bot
lib: improve transferable abort controller exec
367ac71
PR-URL: #45525 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This was referenced Nov 22, 2022
Open
Open
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@anonrig@marco-ippolito
lib: improve AbortController creation duration
e1b7a3c
PR-URL: nodejs#45525 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@anonrig@marco-ippolito
lib: improve transferable abort controller exec
5367586
PR-URL: nodejs#45525 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
@anonrig@ruyadorno
lib: improve AbortController creation duration
5745bcb
PR-URL: #45525 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
@anonrig@ruyadorno
lib: improve transferable abort controller exec
4c9159a
PR-URL: #45525 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadornoruyadorno mentioned this pull request Nov 24, 2022
Merged
@danielleadams
Copy link
Contributor

danielleadams commented Dec 13, 2022

Hi @anonrig - should this PR land in v18.x? If so, it will need a backport PR. Thank you.

anonrig added a commit to anonrig/node that referenced this pull request Jan 3, 2023
@anonrig
lib: improve AbortController creation duration
911ea20
PR-URL: nodejs#45525 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
anonrig added a commit to anonrig/node that referenced this pull request Jan 3, 2023
@anonrig
lib: improve transferable abort controller exec
96ad21b
PR-URL: nodejs#45525 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@anonriganonrig mentioned this pull request Jan 3, 2023
Closed
anonrig added a commit to anonrig/node that referenced this pull request Jan 3, 2023
@anonrig
lib: improve AbortController creation duration
29fa2da
PR-URL: nodejs#45525 Backport-PR-URL: nodejs#46078 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
anonrig added a commit to anonrig/node that referenced this pull request Jan 3, 2023
@anonrig
lib: improve transferable abort controller exec
12bf9b8
PR-URL: nodejs#45525 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.needs-ciPRs that need a full CI run.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig@nodejs-github-bot@aduh95@danielleadams@mcollina