src,node-api: update napi_is_detached_arraybuffer using ArrayBuffer::WasDetached#45538
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This gets `napi_is_detached_arraybuffer(..)` to use the new API, `ArrayBuffer::WasDetached`, that looks more straightforward. Signed-off-by: Daeyeon Jeong <[email protected]>
Collaborator
nodejs-github-bot commented Nov 20, 2022
Review requested:
|
nodejs-github-bot added c++ 
anonrig approved these changes Nov 20, 2022
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
legendecas approved these changes Nov 21, 2022
Collaborator
nodejs-github-bot commented Nov 21, 2022
daeyeon added the author ready 
anonrig added the commit-queue 
Member
mhdawson commented Nov 21, 2022
@daeyeon do you know what version of Node.js contain versions of V8 that support the new API? Just thinking about how we tag in terms of backports. |
15 tasks
Member
anonrig commented Nov 22, 2022
v8 10.9.111 adds this function. Referencing commit v8/v8@9df5ef7 |
MemberAuthor
daeyeon commented Nov 22, 2022
Only the current main (v20-pre) contains the new API and it's added through this patch, 5b8b921. I think its backporting would be possible since the API depends on only v8's internal |
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Nov 22, 2022
Landed in be049df |
13 tasks
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
This gets `napi_is_detached_arraybuffer(..)` to use the new API, `ArrayBuffer::WasDetached`, that looks more straightforward. Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs#45538 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
16 tasks
ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
This gets `napi_is_detached_arraybuffer(..)` to use the new API, `ArrayBuffer::WasDetached`, that looks more straightforward. Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #45538 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
This gets `napi_is_detached_arraybuffer(..)` to use the new API, `ArrayBuffer::WasDetached`, that looks more straightforward. Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #45538 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
This gets `napi_is_detached_arraybuffer(..)` to use the new API, `ArrayBuffer::WasDetached`, that looks more straightforward. Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #45538 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
This gets `napi_is_detached_arraybuffer(..)` to use the new API, `ArrayBuffer::WasDetached`, that looks more straightforward. Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #45538 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
This gets `napi_is_detached_arraybuffer(..)` to use the new API, `ArrayBuffer::WasDetached`, that looks more straightforward. Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #45538 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
This gets `napi_is_detached_arraybuffer(..)` to use the new API, `ArrayBuffer::WasDetached`, that looks more straightforward. Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #45538 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
napi_is_detached_arraybuffer(...)using the new API below which looks more straightforward.node/deps/v8/include/v8-array-buffer.h
Lines 243 to 246 in db88483
Signed-off-by: Daeyeon Jeong [email protected]