test: add missing trailing commas in async-hooks tests#45549
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added async_hooks 
daeyeon approved these changes Nov 20, 2022
Trott approved these changes Nov 21, 2022
Member
Trott commented Nov 21, 2022
Totally tiny nit, but I would drop the word "missing" from the commit message on PRs like this. Whether or not the trailing comma is "missing" might be a matter of interpretation, and "test: add trailing commas in async-hooks tests" conveys the same information more concisely anyway. |
aduh95 added fast-track 
Contributor
Fast-track has been requested by @aduh95. Please 👍 to approve. |
MoLow approved these changes Nov 21, 2022
RaisinTen approved these changes Nov 21, 2022
daeyeon added the commit-queue nodejs-github-bot added commit-queue-failed 
Collaborator
nodejs-github-bot commented Nov 21, 2022
Commit Queue failed- Loading data for nodejs/node/pull/45549 ✔ Done loading data for nodejs/node/pull/45549 ----------------------------------- PR info ------------------------------------ Title test: add missing trailing commas in async-hooks tests (#45549) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:async-hooks-test-dangle -> nodejs:main Labels test, async_hooks, fast-track, author ready Commits 1 - test: add missing trailing commas in async-hooks tests Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/45549 Reviewed-By: Daeyeon Jeong Reviewed-By: Rich Trott Reviewed-By: Moshe Atlow Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45549 Reviewed-By: Daeyeon Jeong Reviewed-By: Rich Trott Reviewed-By: Moshe Atlow Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 20 Nov 2022 17:45:12 GMT ✔ Approvals: 4 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/45549#pullrequestreview-1187343928 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45549#pullrequestreview-1187383240 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45549#pullrequestreview-1188167512 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45549#pullrequestreview-1188177168 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3514762851 |
daeyeon added request-ci 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 21, 2022
anonrig approved these changes Nov 21, 2022
ContributorAuthor
aduh95 commented Nov 21, 2022
Landed in cf46746 |
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
PR-URL: #45549 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This was referenced Nov 22, 2022
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
PR-URL: nodejs#45549 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
16 tasks
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45549 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45549 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #45549 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
PR-URL: #45549 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #45549 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.