node-api: address coverity warning#45563
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 21, 2022
Review requested:
|
nodejs-github-bot added c++ 
MemberAuthor
This is the report. I think technically it may be a false positive, but initializing the variable seems ok as well, so PR does that versus marking as false positive. / Create a new napi_env forthis specific module. 634 napi_env env = v8impl::NewEnv(context, module_filename); 6353. var_decl: Declaring variable _exports without initializer. 636 napi_value _exports; 637 env->CallIntoModule([&](napi_env env){638 _exports = init(env, v8impl::JsValueFromV8LocalValue(exports)); 639 }); 640641// If register function returned a non-null exports object different from642// the exports object we passed it, set that as the "exports" property of643// the module. CID 276441 (#1 of 1): Uninitialized pointer read (UNINIT) 4. uninit_use: Using uninitialized value _exports. 644 if (_exports != nullptr && 645 _exports != v8impl::JsValueFromV8LocalValue(exports)){646 napi_value _module = v8impl::JsValueFromV8LocalValue(module); 647napi_set_named_property(env, _module, "exports", _exports); 648 } |
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <[email protected]>
cjihrig approved these changes Nov 21, 2022
richardlau approved these changes Nov 21, 2022
daeyeon added author ready 
daeyeon approved these changes Nov 22, 2022
Trott approved these changes Nov 22, 2022
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 22, 2022
legendecas approved these changes Nov 22, 2022
Collaborator
nodejs-github-bot commented Nov 22, 2022
Collaborator
nodejs-github-bot commented Nov 22, 2022
lpinca approved these changes Nov 22, 2022
mhdawson added a commit that referenced this pull request Nov 24, 2022
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45563 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MemberAuthor
mhdawson commented Nov 24, 2022
Landed in 0bbef56 |
ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45563 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Nov 30, 2022
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#45563 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45563 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45563 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45563 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45563 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45563 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Dawson [email protected]