benchmark: introduce benchmark combination filtering#45735
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Dec 4, 2022
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
mscdexforce-pushed the benchmark-filter-combinations branch from 3c160ad to 3b7423bCompareCollaborator
nodejs-github-bot commented Dec 4, 2022
daeyeon reviewed Dec 5, 2022
Uh oh!
There was an error while loading. Please reload this page.
anonrig approved these changes Dec 5, 2022
daeyeon approved these changes Dec 5, 2022
lpinca approved these changes Dec 6, 2022
BridgeAR approved these changes Dec 6, 2022
This was referenced Dec 7, 2022
RafaelGSS approved these changes Dec 8, 2022
This was referenced Dec 9, 2022
Collaborator
nodejs-github-bot commented Jan 18, 2023
anonrig approved these changes Jan 18, 2023
14 tasks
Collaborator
nodejs-github-bot commented Jan 19, 2023
This was referenced Jan 20, 2023
Collaborator
nodejs-github-bot commented Jan 22, 2023
lpinca added commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 22, 2023
Landed in cc18fd9...863a416 |
nodejs-github-bot pushed a commit that referenced this pull request Jan 22, 2023
PR-URL: #45735 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jan 22, 2023
PR-URL: #45735 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
This was referenced Jan 23, 2023
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
PR-URL: #45735 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
PR-URL: #45735 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
PR-URL: #45735 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
PR-URL: #45735 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
PR-URL: #45735 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
PR-URL: #45735 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help avoid redundant/unnecessary benchmark runs. For this PR, I've only included changes for Buffer benchmarks that would benefit from this.
If this is acceptable, the other benchmark categories would need to be reviewed and modified where appropriate as well, probably in additional PRs?