test_runner: refactor tap_parser to use more primordials#45745
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added dont-land-on-v14.x needs-ci 
MoLow approved these changes Dec 5, 2022
aduh95 added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Dec 5, 2022
cjihrig approved these changes Dec 5, 2022
Uh oh!
There was an error while loading. Please reload this page.
benjamingr previously requested changes Dec 6, 2022
Member
benjamingr left a comment
benjamingr left a comment There was a problem hiding this comment.
Changes LGTM, "request changes"ing so no one lands this by mistake without benchmarks showing no regression.
If benchmarks were run - feel free to treat this "request changes" as a "lgtm"
ContributorAuthor
@benjamingr we don't have benchmarks for the test runner, and IMO robustness is much more important than performance for a test runner anyway. (also it seems unlikely to me that this change would impact perf by any significant manner, but I don't have any data to back this up) |
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
aduh95 added request-ci github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Dec 6, 2022
anonrig approved these changes Dec 6, 2022
This was referenced Dec 7, 2022
Collaborator
nodejs-github-bot commented Dec 8, 2022
5 tasks
cjihrig added author ready This was referenced Dec 10, 2022
cjihrig added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Dec 11, 2022
Landed in 7a42a20 |
ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Dec 12, 2022
PR-URL: nodejs#45745 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Dec 12, 2022
PR-URL: #45745 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Dec 13, 2022
PR-URL: #45745 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45745 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45745 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #45745 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
PR-URL: #45745 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #45745 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
PR-URL: nodejs/node#45745 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> (cherry picked from commit 7a42a206ac37d95060640b4812aaef32535937e1)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.