deps: V8: cherry-pick 30861a39323d#45851
Closed
+2 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original commit message: [debug] Re-enable internal [[Scopes]] property We received feedback that the [[Scopes]] property has some legitimate use-cases not covered by the Scopes View during pause. We re-enable the feature for now and will remove the flag in a follow-up. [email protected] Bug: chromium:1365858 Change-Id: Ibf279ae6c4f5ae492d03e9b4ee7316f6500508d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4099385 Auto-Submit: Simon Zünd <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Commit-Queue: Simon Zünd <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/main@{#84800} Refs: v8/v8@30861a3
Collaborator
nodejs-github-bot commented Dec 14, 2022
Review requested:
|
nodejs-github-bot added build 
anonrig approved these changes Dec 14, 2022
anonrig added the author ready 
Member
anonrig commented Dec 14, 2022
Thanks for the cherry-pick. I'm in favor of landing this before the end of 2022. |
ContributorAuthor
AaronFriel commented Dec 14, 2022
That's great to hear, we'd love to remove our advisory against using Node.js 19.2 or newer! |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Dec 14, 2022
Collaborator
nodejs-github-bot commented Dec 14, 2022
Collaborator
nodejs-github-bot commented Dec 14, 2022
targos approved these changes Dec 14, 2022
Collaborator
nodejs-github-bot commented Dec 14, 2022
9 tasks
Collaborator
nodejs-github-bot commented Dec 15, 2022
7 tasks
ContributorAuthor
AaronFriel commented Dec 16, 2022
This was referenced Dec 17, 2022
jasnell approved these changes Dec 19, 2022
Collaborator
nodejs-github-bot commented Dec 19, 2022
This was referenced Dec 20, 2022
Collaborator
nodejs-github-bot commented Dec 21, 2022
14 tasks
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Dec 28, 2022
Collaborator
nodejs-github-bot commented Dec 28, 2022
Collaborator
nodejs-github-bot commented Dec 28, 2022
targos pushed a commit that referenced this pull request Jan 1, 2023
Original commit message: [debug] Re-enable internal [[Scopes]] property We received feedback that the [[Scopes]] property has some legitimate use-cases not covered by the Scopes View during pause. We re-enable the feature for now and will remove the flag in a follow-up. [email protected] Bug: chromium:1365858 Change-Id: Ibf279ae6c4f5ae492d03e9b4ee7316f6500508d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4099385 Auto-Submit: Simon Zünd <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Commit-Queue: Simon Zünd <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/main@{#84800} Refs: v8/v8@30861a3 PR-URL: #45851 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
targos commented Jan 1, 2023
Landed in 71b9f79 |
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2023
Original commit message: [debug] Re-enable internal [[Scopes]] property We received feedback that the [[Scopes]] property has some legitimate use-cases not covered by the Scopes View during pause. We re-enable the feature for now and will remove the flag in a follow-up. [email protected] Bug: chromium:1365858 Change-Id: Ibf279ae6c4f5ae492d03e9b4ee7316f6500508d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4099385 Auto-Submit: Simon Zünd <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Commit-Queue: Simon Zünd <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/main@{#84800} Refs: v8/v8@30861a3 PR-URL: #45851 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
Original commit message: [debug] Re-enable internal [[Scopes]] property We received feedback that the [[Scopes]] property has some legitimate use-cases not covered by the Scopes View during pause. We re-enable the feature for now and will remove the flag in a follow-up. [email protected] Bug: chromium:1365858 Change-Id: Ibf279ae6c4f5ae492d03e9b4ee7316f6500508d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4099385 Auto-Submit: Simon Zünd <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Commit-Queue: Simon Zünd <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/main@{#84800} Refs: v8/v8@30861a3 PR-URL: #45851 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
Original commit message: [debug] Re-enable internal [[Scopes]] property We received feedback that the [[Scopes]] property has some legitimate use-cases not covered by the Scopes View during pause. We re-enable the feature for now and will remove the flag in a follow-up. [email protected] Bug: chromium:1365858 Change-Id: Ibf279ae6c4f5ae492d03e9b4ee7316f6500508d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4099385 Auto-Submit: Simon Zünd <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Commit-Queue: Simon Zünd <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/main@{#84800} Refs: v8/v8@30861a3 PR-URL: #45851 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@30861a3
See also: #45845